third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2225033003: Separate backgroundObscurationStatus and hasBoxDecorationBackground

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2225033003: Separate backgroundObscurationStatus and hasBoxDecorationBackground (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 41dba4ef9b60ad6c8700410bd6eb1b2720df4d7f..ba5f5295b2175d1fa3d7ba2b08e9dcd418d032c1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -1388,10 +1388,10 @@ PaintInvalidationReason LayoutObject::invalidatePaintIfNeeded(const PaintInvalid

"object", this->debugName().ascii(),

"info", jsonObjectForOldAndNewRects(oldBounds, oldLocation, newBounds, newLocation));

- bool boxDecorationBackgroundObscured = boxDecorationBackgroundIsKnownToBeObscured();

- if (!isFullPaintInvalidationReason(invalidationReason) && boxDecorationBackgroundObscured != m_bitfields.lastBoxDecorationBackgroundObscured())

+ bool backgroundObscured = backgroundIsKnownToBeObscured();

+ if (!isFullPaintInvalidationReason(invalidationReason) && backgroundObscured != m_bitfields.previousBackgroundObscured())

invalidationReason = PaintInvalidationBackgroundObscurationChange;

- m_bitfields.setLastBoxDecorationBackgroundObscured(boxDecorationBackgroundObscured);

+ m_bitfields.setPreviousBackgroundObscured(backgroundObscured);

if (invalidationReason == PaintInvalidationNone) {

// TODO(trchen): Currently we don't keep track of paint offset of layout objects.