third_party/WebKit/Source/core/layout/LayoutImage.cpp - Issue 2225033003: Separate backgroundObscurationStatus and hasBoxDecorationBackground

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutImage.cpp

Issue 2225033003: Separate backgroundObscurationStatus and hasBoxDecorationBackground (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutImage.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutImage.cpp b/third_party/WebKit/Source/core/layout/LayoutImage.cpp

index a582faf0c63e7c1a67eccdf9170ff683c4d81c42..e2c218ee307c366118ab6f71b3422e6b565abd64 100644

--- a/third_party/WebKit/Source/core/layout/LayoutImage.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutImage.cpp

@@ -209,7 +209,7 @@ bool LayoutImage::boxShadowShouldBeAppliedToBackground(BackgroundBleedAvoidance

if (!LayoutBoxModelObject::boxShadowShouldBeAppliedToBackground(bleedAvoidance))

return false;

- return !const_cast<LayoutImage*>(this)->boxDecorationBackgroundIsKnownToBeObscured();

+ return !const_cast<LayoutImage*>(this)->backgroundIsKnownToBeObscured();

}

bool LayoutImage::foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect, unsigned) const

@@ -243,7 +243,7 @@ bool LayoutImage::foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect,

bool LayoutImage::computeBackgroundIsKnownToBeObscured() const

{

- if (!hasBackground())

+ if (!styleRef().hasBackground())

return false;

LayoutRect paintedExtent;

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »