Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2225023002: binding: Updates a layout test for exception's creation context. (Closed)

Created:
4 years, 4 months ago by Yuki
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Updates a layout test for exception's creation context. I'm planning to make a change so that Exceptions are always created in the current context. Before doing that, I'd like to improve an existing layout test so that we can clearly see the coming change. BUG=618672 Committed: https://crrev.com/72fe6ccc8889f01f4c6d60fb54e76c6fa964277a Cr-Commit-Position: refs/heads/master@{#410569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/cross-frame-accessor-throw.html View 3 chunks +46 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/cross-frame-accessor-throw-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yuki
Could you review this CL?
4 years, 4 months ago (2016-08-08 14:28:01 UTC) #4
haraken
LGTM
4 years, 4 months ago (2016-08-08 14:31:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225023002/1
4 years, 4 months ago (2016-08-09 03:46:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 03:50:26 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 03:52:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72fe6ccc8889f01f4c6d60fb54e76c6fa964277a
Cr-Commit-Position: refs/heads/master@{#410569}

Powered by Google App Engine
This is Rietveld 408576698