Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: test/cctest/test-conversions.cc

Issue 2225013002: Remove unused isolate parameter from NumberToSize and TryNumberToSize (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-conversions.cc
diff --git a/test/cctest/test-conversions.cc b/test/cctest/test-conversions.cc
index 84bbc59d8a1627a9616f6f5c0eb320b8c7120264..9569dc867857dd13a82c35e14ca3ba0bed48ab22 100644
--- a/test/cctest/test-conversions.cc
+++ b/test/cctest/test-conversions.cc
@@ -413,7 +413,7 @@ TEST(NoHandlesForTryNumberToSize) {
{
SealHandleScope no_handles(isolate);
Smi* smi = Smi::FromInt(1);
- CHECK(TryNumberToSize(isolate, smi, &result));
+ CHECK(TryNumberToSize(smi, &result));
CHECK_EQ(result, 1);
}
result = 0;
@@ -422,14 +422,14 @@ TEST(NoHandlesForTryNumberToSize) {
Handle<HeapNumber> heap_number1 = isolate->factory()->NewHeapNumber(2.0);
{
SealHandleScope no_handles(isolate);
- CHECK(TryNumberToSize(isolate, *heap_number1, &result));
+ CHECK(TryNumberToSize(*heap_number1, &result));
CHECK_EQ(result, 2);
}
Handle<HeapNumber> heap_number2 = isolate->factory()->NewHeapNumber(
static_cast<double>(std::numeric_limits<size_t>::max()) + 10000.0);
{
SealHandleScope no_handles(isolate);
- CHECK(!TryNumberToSize(isolate, *heap_number2, &result));
+ CHECK(!TryNumberToSize(*heap_number2, &result));
}
}
}
« no previous file with comments | « src/runtime/runtime-utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698