src/runtime/runtime-strings.cc - Issue 2225013002: Remove unused isolate parameter from NumberToSize and TryNumberToSize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-strings.cc

Issue 2225013002: Remove unused isolate parameter from NumberToSize and TryNumberToSize (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-strings.cc

diff --git a/src/runtime/runtime-strings.cc b/src/runtime/runtime-strings.cc

index 761176d54a3ae8f83ca58b7f7301d07327fc9db2..517513ed4e42230ecdc92c2e1afc7da34d9a5a67 100644

--- a/src/runtime/runtime-strings.cc

+++ b/src/runtime/runtime-strings.cc

@@ -399,7 +399,7 @@ RUNTIME_FUNCTION(Runtime_StringBuilderConcat) {

CONVERT_ARG_HANDLE_CHECKED(String, special, 2);

size_t actual_array_length = 0;

- CHECK(TryNumberToSize(isolate, array->length(), &actual_array_length));

+ CHECK(TryNumberToSize(array->length(), &actual_array_length));

CHECK(array_length >= 0);

CHECK(static_cast<size_t>(array_length) <= actual_array_length);

« no previous file with comments | « src/runtime/runtime-simd.cc ('k') | src/runtime/runtime-typedarray.cc » ('j') | no next file with comments »