Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2225013002: Remove unused isolate parameter from NumberToSize and TryNumberToSize (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused isolate parameter from NumberToSize and TryNumberToSize BUG= Committed: https://crrev.com/63f41fcdc5d5a1ffcbb7ed3e71304e003ad236e5 Cr-Commit-Position: refs/heads/master@{#38449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -113 lines) Patch
M src/api.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/builtins/builtins-arraybuffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/conversions.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/conversions-inl.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/futex-emulation.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/array-buffer-tracker-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-atomics.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M src/runtime/runtime-futex.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/runtime/runtime-simd.cc View 1 chunk +39 lines, -39 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-typedarray.cc View 10 chunks +23 lines, -31 lines 0 comments Download
M src/runtime/runtime-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-conversions.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Hannes Payer (out of office)
lgtm
4 years, 4 months ago (2016-08-08 15:51:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225013002/1
4 years, 4 months ago (2016-08-08 15:52:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 15:54:39 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 15:56:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63f41fcdc5d5a1ffcbb7ed3e71304e003ad236e5
Cr-Commit-Position: refs/heads/master@{#38449}

Powered by Google App Engine
This is Rietveld 408576698