Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2225003002: Handle HTTP header parameters with empty values better (Closed)

Created:
4 years, 4 months ago by Søren Gjesse
Modified:
4 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, rmacnak, Cutch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle HTTP header parameters with empty values better This handles the null issue reported. Closes #26598 BUG= https://github.com/dart-lang/sdk/issues/26958 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/f9404b969ba0b244fbff6dc8aa0388c57f3ad577

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M CHANGELOG.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/http_headers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_headers_test.dart View 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Søren Gjesse
4 years, 4 months ago (2016-08-08 14:03:30 UTC) #1
floitsch
LGTM.
4 years, 4 months ago (2016-08-08 14:16:54 UTC) #2
floitsch
Consider adding an entry to the changelog.
4 years, 4 months ago (2016-08-08 14:17:07 UTC) #3
Søren Gjesse
On 2016/08/08 14:17:07, floitsch wrote: > Consider adding an entry to the changelog. Updated CHANGELOG.
4 years, 4 months ago (2016-08-08 14:32:02 UTC) #4
floitsch
Changelog update LGTM.
4 years, 4 months ago (2016-08-08 14:33:52 UTC) #5
Søren Gjesse
4 years, 4 months ago (2016-08-08 14:35:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f9404b969ba0b244fbff6dc8aa0388c57f3ad577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698