Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2224913002: [turbolizer] Output correct JSON when source contains a backslash. (Closed)

Created:
4 years, 4 months ago by bgeron
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, oth, rmcilroy, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Output correct JSON when source contains a backslash. Previously, we would output \x5c to escape a backslash, but this is invalid JSON and it would crash Turbolizer. Use \u005c instead. BUG= Committed: https://crrev.com/b5f4de918610a1a6a9f8e2ad8be8d8d0d455453b Cr-Commit-Position: refs/heads/master@{#38479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/ostreams.cc View 2 chunks +9 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/RegExpLiterals.golden View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
bgeron
PTAL.
4 years, 4 months ago (2016-08-08 10:43:39 UTC) #2
Jarin
lgtm
4 years, 4 months ago (2016-08-09 07:52:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224913002/1
4 years, 4 months ago (2016-08-09 08:48:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 09:18:19 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 09:18:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5f4de918610a1a6a9f8e2ad8be8d8d0d455453b
Cr-Commit-Position: refs/heads/master@{#38479}

Powered by Google App Engine
This is Rietveld 408576698