Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2224893004: DevTools: focus editor when SourcesPanel is shown (Closed)

Created:
4 years, 4 months ago by lushnikov
Modified:
4 years, 4 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: focus editor when SourcesPanel is shown This was regressed in crrev.com/2202053009 BUG=634826 R=dgozman, pfeldman Committed: https://crrev.com/23241d9a578ec2723f7b9ad13c27b760585447e2 Cr-Commit-Position: refs/heads/master@{#410530}

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/inspector/sources/sources-panel-focus-editor-on-select.html View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/sources-panel-focus-editor-on-select-expected.txt View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
lushnikov
please, take a look
4 years, 4 months ago (2016-08-08 21:41:34 UTC) #1
dgozman
Can we have a test? Bug reporter claims this happened before.
4 years, 4 months ago (2016-08-08 22:00:17 UTC) #4
lushnikov
sure, he comes the test!
4 years, 4 months ago (2016-08-08 22:34:42 UTC) #5
dgozman
lgtm
4 years, 4 months ago (2016-08-08 22:57:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224893004/40001
4 years, 4 months ago (2016-08-08 23:05:00 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/203772)
4 years, 4 months ago (2016-08-08 23:20:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224893004/40001
4 years, 4 months ago (2016-08-09 02:09:47 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-09 02:23:01 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 02:25:37 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/23241d9a578ec2723f7b9ad13c27b760585447e2
Cr-Commit-Position: refs/heads/master@{#410530}

Powered by Google App Engine
This is Rietveld 408576698