Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2224823004: template intersection fuzz fixes (Closed)

Created:
4 years, 4 months ago by caryclark
Modified:
4 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

template intersection fuzz fixes Plumb in the ability to ignore asserts for out of range input deeper into the template intersection code. Exit gracefully when error conditions are found. TBR=reed@google.com BUG=632607, 632628, 633063, 633065, 634251, 633608 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2224823004 Committed: https://skia.googlesource.com/skia/+/643ede69216c073c2dd497c382577dc9fde36b3e

Patch Set 1 #

Patch Set 2 : one more fuzz fix #

Patch Set 3 : fix for 633608 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -20 lines) Patch
M src/pathops/SkOpCoincidence.cpp View 1 2 4 chunks +12 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 23 chunks +56 lines, -15 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 2 chunks +325 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224823004/40001
4 years, 4 months ago (2016-08-08 21:04:50 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 21:27:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/643ede69216c073c2dd497c382577dc9fde36b3e

Powered by Google App Engine
This is Rietveld 408576698