Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1574)

Issue 2224793003: Only conditionally add inner scope when deserializing (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only conditionally add inner scope when deserializing BUG=v8:5209 Committed: https://crrev.com/2ed9e6e634dc46a08f1da2eebef82e3e563d6e72 Cr-Commit-Position: refs/heads/master@{#38436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/ast/scopes.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/ast/scopes.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-08 11:20:51 UTC) #2
marja
lgtm
4 years, 4 months ago (2016-08-08 11:23:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224793003/1
4 years, 4 months ago (2016-08-08 11:24:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 11:51:31 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 11:54:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ed9e6e634dc46a08f1da2eebef82e3e563d6e72
Cr-Commit-Position: refs/heads/master@{#38436}

Powered by Google App Engine
This is Rietveld 408576698