Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2224763002: Make compile_xcassets.py less verbose. (Closed)

Created:
4 years, 4 months ago by sdefresne
Modified:
4 years, 4 months ago
Reviewers:
brettw, justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup-xctest-config
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make compile_xcassets.py less verbose. Parse output of actool and discard uninteresting messages and fail on unexpected warning messages (as actool termines with a success error code even if some resources are missing). BUG=635306 Committed: https://crrev.com/5b150b0a5a28f95f651767f901819390fc065676 Cr-Commit-Position: refs/heads/master@{#410824}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase on origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -17 lines) Patch
M build/toolchain/mac/compile_xcassets.py View 2 chunks +51 lines, -17 lines 0 comments Download

Messages

Total messages: 29 (20 generated)
sdefresne
Please take a look.
4 years, 4 months ago (2016-08-07 09:06:18 UTC) #4
justincohen
lgtm LGTM. This seems like a good place for a test. Is there a test ...
4 years, 4 months ago (2016-08-08 01:20:43 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2220243002 Patch 40001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-08 01:20:54 UTC) #10
sdefresne
Brett, can you review as OWNERS of build/toolchain/mac?
4 years, 4 months ago (2016-08-09 04:33:24 UTC) #14
brettw
rs lgtm
4 years, 4 months ago (2016-08-09 20:02:06 UTC) #22
sdefresne
On 2016/08/08 01:20:43, justincohen wrote: > lgtm > > LGTM. > > This seems like ...
4 years, 4 months ago (2016-08-09 20:16:12 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224763002/60001
4 years, 4 months ago (2016-08-09 20:19:20 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-09 21:23:05 UTC) #27
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 21:24:31 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5b150b0a5a28f95f651767f901819390fc065676
Cr-Commit-Position: refs/heads/master@{#410824}

Powered by Google App Engine
This is Rietveld 408576698