|
|
DescriptionMake compile_xcassets.py less verbose.
Parse output of actool and discard uninteresting messages and
fail on unexpected warning messages (as actool termines with
a success error code even if some resources are missing).
BUG=635306
Committed: https://crrev.com/5b150b0a5a28f95f651767f901819390fc065676
Cr-Commit-Position: refs/heads/master@{#410824}
Patch Set 1 #Patch Set 2 : Rebase. #Patch Set 3 : Rebase #Patch Set 4 : Rebase on origin/master #
Messages
Total messages: 29 (20 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + justincohen@chromium.org
Please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by justincohen@chromium.org
lgtm LGTM. This seems like a good place for a test. Is there a test suite for this? Any ideas?
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2220243002 Patch 40001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was unchecked by justincohen@chromium.org
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
sdefresne@chromium.org changed reviewers: + brettw@chromium.org
Brett, can you review as OWNERS of build/toolchain/mac?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
rs lgtm
On 2016/08/08 01:20:43, justincohen wrote: > lgtm > > LGTM. > > This seems like a good place for a test. Is there a test suite for this? Any > ideas? No there is no test suite for this.
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from justincohen@chromium.org, brettw@chromium.org Link to the patchset: https://codereview.chromium.org/2224763002/#ps60001 (title: "Rebase on origin/master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Make compile_xcassets.py less verbose. Parse output of actool and discard uninteresting messages and fail on unexpected warning messages (as actool termines with a success error code even if some resources are missing). BUG=635306 ========== to ========== Make compile_xcassets.py less verbose. Parse output of actool and discard uninteresting messages and fail on unexpected warning messages (as actool termines with a success error code even if some resources are missing). BUG=635306 Committed: https://crrev.com/5b150b0a5a28f95f651767f901819390fc065676 Cr-Commit-Position: refs/heads/master@{#410824} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/5b150b0a5a28f95f651767f901819390fc065676 Cr-Commit-Position: refs/heads/master@{#410824} |