Issue 222473002: SkTDynamicHash: pick up GetKey(), Hash() from T by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 222473002: SkTDynamicHash: pick up GetKey(), Hash() from T by default. (Closed)

Created:
6 years, 8 months ago by mtklein_C

Modified:
6 years, 8 months ago

Reviewers:
bsalomon, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

SkTDynamicHash: pick up GetKey(), Hash() from T by default. This also has a somewhat obscure technical benefit: it removes the requirement that GetKey() and Hash() must be functions with external linkage, which is required when passing a function pointer to a template. A future CL that's run into this problem and the obvious simplification are about 50/50 why I'm sending this CL. BUG=skia: DIFFBASE= https://codereview.chromium.org/222343002/ Committed: http://code.google.com/p/skia/source/detail?r=14028

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -37 lines)			Patch
M	src/core/SkPictureFlat.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/core/SkScaledImageCache.cpp	View	2 chunks	+5 lines, -15 lines	0 comments	Download
M	src/core/SkTDynamicHash.h	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	src/gpu/GrResourceCache.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/gpu/GrTMultiMap.h	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	tests/DynamicHashTest.cpp	View	2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/222473002/1

6 years, 8 months ago (2014-04-02 17:30:11 UTC) #4

Message was sent while issue was closed.

Change committed as 14028

Expand Messages | Collapse Messages