content/renderer/renderer_blink_platform_impl.h - Issue 2224713002: Move WebSocketHandleImpl into Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_blink_platform_impl.h

Issue 2224713002: Move WebSocketHandleImpl into Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review feedback except the location of websocket.mojom Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/renderer_blink_platform_impl.h

diff --git a/content/renderer/renderer_blink_platform_impl.h b/content/renderer/renderer_blink_platform_impl.h

index 5799264ece9197541e380814b98ac7c1e13270e7..78f86a55a449c7813e470e7c4c5370620a6df958 100644

--- a/content/renderer/renderer_blink_platform_impl.h

+++ b/content/renderer/renderer_blink_platform_impl.h

@@ -92,7 +92,6 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {

bool isLinkVisited(unsigned long long linkHash) override;

void createMessageChannel(blink::WebMessagePortChannel** channel1,

blink::WebMessagePortChannel** channel2) override;

- blink::WebSocketHandle* createWebSocketHandle() override;

blink::WebPrescientNetworking* prescientNetworking() override;

void cacheMetadata(const blink::WebURL&,

int64_t,