third_party/WebKit/public/platform/modules/websockets/OWNERS - Issue 2224713002: Move WebSocketHandleImpl into Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/websockets/OWNERS

Issue 2224713002: Move WebSocketHandleImpl into Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issue w/ Java bindings missing a dependency Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 tyoshino@chromium.org	1 tyoshino@chromium.org

2 yhirano@chromium.org	2 yhirano@chromium.org
	yhirano 2016/08/24 05:01:00 I originally created this directory in order to gi I originally created this directory in order to give us ownership of the related files. Now they are gone and only websocket.mojom remains while we don't have the ownership of the file. Should we keep this directory, or delete it and move websocket.mojom to somewhere? darin (slow to review) 2016/08/24 17:15:05 Good point. However, I'm not sure where else to mo Show quoted text On 2016/08/24 05:01:00, yhirano wrote: > I originally created this directory in order to give us ownership of the related > files. Now they are gone and only websocket.mojom remains while we don't have > the ownership of the file. Should we keep this directory, or delete it and move > websocket.mojom to somewhere? Good point. However, I'm not sure where else to move it. We will surely end up with more similar cases as more and more public header files are replaced with mojoms. Maybe then we will see what organizational pattern should replace the current model?
	3

	4 per-file *.mojom=set noparent

	5 per-file *.mojom=file://ipc/SECURITY_OWNERS

OLD	NEW