Move WebSocketHandleImpl into Blink

third_party/WebKit/Source/modules/websockets/WebSocketHandleClient.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebSocketHandleClient_h
 #define WebSocketHandleClient_h
 
-#include "public/platform/WebCommon.h"
-#include "public/platform/WebString.h"
-#include "public/platform/modules/websockets/WebSocketHandle.h"
+#include "modules/websockets/WebSocketHandle.h"

[yhirano, 2016/08/24 05:01:00]

+wtf/Forward.h

[darin (slow to review), 2016/08/24 17:15:05]

Done.

 
 namespace blink {
-
-class WebSocketHandshakeRequestInfo;
-class WebSocketHandshakeResponseInfo;
+class WebSocketHandshakeRequest;
+class WebSocketHandshakeResponse;
 
 class WebSocketHandleClient {
 public:
     // Called when the handle is opened.
-    virtual void didConnect(WebSocketHandle*, const WebString& selectedProtocol, const WebString& extensions) = 0;
+    virtual void didConnect(WebSocketHandle*, const String& selectedProtocol, const String& extensions) = 0;
 
     // Called when the browser starts the opening handshake.
     // This notification can be omitted when the inspector is not active.
-    virtual void didStartOpeningHandshake(WebSocketHandle*, const WebSocketHandshakeRequestInfo&) = 0;
+    virtual void didStartOpeningHandshake(WebSocketHandle*, PassRefPtr<WebSocketHandshakeRequest>) = 0;
 
     // Called when the browser finishes the opening handshake.
     // This notification precedes didConnect.
     // This notification can be omitted when the inspector is not active.
-    virtual void didFinishOpeningHandshake(WebSocketHandle*, const WebSocketHandshakeResponseInfo&) = 0;
+    virtual void didFinishOpeningHandshake(WebSocketHandle*, const WebSocketHandshakeResponse*) = 0;
 
     // Called when the browser is required to fail the connection.
     // |message| can be displayed in the inspector, but should not be passed
     // to scripts.
     // This message also implies that channel is closed with
     // (wasClean = false, code = 1006, reason = "") and
     // |handle| becomes unavailable.
-    virtual void didFail(WebSocketHandle* /* handle */, const WebString& message) = 0;

[yhirano, 2016/08/24 05:01:00]

Can you leave a commented out parameter name if it is used in the function
comment? Ditto below.

[darin (slow to review), 2016/08/24 17:15:05]

Done.

+    virtual void didFail(WebSocketHandle*, const String& message) = 0;
 
     // Called when data are received.
-    virtual void didReceiveData(WebSocketHandle*, bool fin, WebSocketHandle::MessageType, const char* data, size_t /* size */) = 0;
+    virtual void didReceiveData(WebSocketHandle*, bool fin, WebSocketHandle::MessageType, const char* data, size_t) = 0;
 
     // Called when the handle is closed.
     // |handle| becomes unavailable once this notification arrives.
-    virtual void didClose(WebSocketHandle* /* handle */, bool wasClean, unsigned short code, const WebString& reason) = 0;
+    virtual void didClose(WebSocketHandle*, bool wasClean, unsigned short code, const String& reason) = 0;
 
     virtual void didReceiveFlowControl(WebSocketHandle*, int64_t quota) = 0;
 
     // Called when the browser receives a Close frame from the remote
     // server. Not called when the renderer initiates the closing handshake.
     virtual void didStartClosingHandshake(WebSocketHandle*) = 0;
 };
 
 } // namespace blink
 
 #endif // WebSocketHandleClient_h