MD Settings: simplify animation scheduling

MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This removes TransitionBehavior and simplifies MainPageBehavior.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/50f1d1ddcccb390b00dd91ff5b6881010e295c15
Cr-Commit-Position: refs/heads/master@{#410844}

[michaelpg, 2016-08-06 02:56:27]

Description was changed from

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This also merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

BUG=
==========

to

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This also merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-06 02:56:46]

Description was changed from

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This also merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This also merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-06 03:21:30]

Description was changed from

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This also merges RoutableBehavior into MainPageBehavior since there's no clear
separation between them anymore, and "Routable" is a weird name.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-06 04:03:57]

Description was changed from

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This removes TransitionBehavior and simplifies MainPageBehavior.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-06 04:03:59]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org

[michaelpg, 2016-08-06 04:05:35]

dan: PTAL. this makes things moar stable, and is the last thing to do before
updating the collapse animation to suck less. note this depends on
https://codereview.chromium.org/2211303004/ which cleans up MainPageBehavior a
bit.

[Dan Beam, 2016-08-09 18:15:19]

lgtm but is there anything worth testing here?

https://codereview.chromium.org/2224673002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/2224673002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:102: * If
the current animation is inconsistent with the current route, stops the
stops -> stop?

https://codereview.chromium.org/2224673002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:109:
this.$$('settings-section.expanding, settings-section.collapsing'));
i assume it's impossible for these both to exist at once?

[michaelpg, 2016-08-09 20:43:22]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-08-09 20:43:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2224673002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-09 20:43:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-08-09 20:44:03]

On 2016/08/09 18:15:19, Dan Beam wrote:
> lgtm but is there anything worth testing here?

yes. I have test CLs open but haven't hammered out the flakes. I'll give it
another go.

https://codereview.chromium.org/2224673002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/2224673002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:102: * If
the current animation is inconsistent with the current route, stops the
On 2016/08/09 18:15:19, Dan Beam wrote:
> stops -> stop?

figure it should still be indicative, like other function comments

https://codereview.chromium.org/2224673002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:109:
this.$$('settings-section.expanding, settings-section.collapsing'));
On 2016/08/09 18:15:19, Dan Beam wrote:
> i assume it's impossible for these both to exist at once?

That's the idea, enforced by tryTransitionToSection_ and the animation promises
removing these classes before unsetting currentAnimation_.

[commit-bot: I haz the power, 2016-08-09 22:04:57]

Description was changed from

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This removes TransitionBehavior and simplifies MainPageBehavior.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This removes TransitionBehavior and simplifies MainPageBehavior.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-09 22:04:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-09 22:06:14]

Description was changed from

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This removes TransitionBehavior and simplifies MainPageBehavior.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: simplify animation scheduling

The logic to schedule multiple expand/collapse animations when they're already
running is buggy, and this almost never happens anyway. Replace with simpler
logic:

1. If the UI matches currentRoute, stop.
2. If no animation is playing, animate to match currentRoute.
3. Otherwise, finish/cancel the animation if necessary.

This removes TransitionBehavior and simplifies MainPageBehavior.

BUG=589681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/50f1d1ddcccb390b00dd91ff5b6881010e295c15
Cr-Commit-Position: refs/heads/master@{#410844}
==========

[commit-bot: I haz the power, 2016-08-09 22:06:15]

Patchset 4 (id:??) landed as
https://crrev.com/50f1d1ddcccb390b00dd91ff5b6881010e295c15
Cr-Commit-Position: refs/heads/master@{#410844}