Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2224643002: Move device monitors out of //media/capture into //media/device_monitors (Closed)

Created:
4 years, 4 months ago by mcasas
Modified:
4 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move device monitors out of //media/capture into //media/device_monitors This is (another) preparation CL for the linked bug. Device monitors are in capture/ for unknown reasons but they don't belong there, since they effectively monitor all audio and video devices in the system. Folders are cheap, so I moved them out, further clearing the way for moving //media/capture around, and paves the way to reusing functionality that is now in //device. BUG=626125 NOPRESUBMIT=true (this CL has the necessary LGTMs but it hits an incorrect git cl format media presubmit check). Committed: https://crrev.com/c41614771c0e7efac7971738c81d05118cc31709 Cr-Commit-Position: refs/heads/master@{#411181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -968 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 3 chunks +13 lines, -0 lines 0 comments Download
M media/capture/BUILD.gn View 3 chunks +0 lines, -13 lines 0 comments Download
D media/capture/device_monitor_mac.h View 1 chunk +0 lines, -53 lines 0 comments Download
D media/capture/device_monitor_mac.mm View 1 chunk +0 lines, -475 lines 0 comments Download
D media/capture/device_monitor_udev.h View 1 chunk +0 lines, -57 lines 0 comments Download
D media/capture/device_monitor_udev.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D media/capture/system_message_window_win.h View 1 chunk +0 lines, -54 lines 0 comments Download
D media/capture/system_message_window_win.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D media/capture/system_message_window_win_unittest.cc View 1 chunk +0 lines, -46 lines 0 comments Download
A + media/device_monitors/device_monitor_mac.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + media/device_monitors/device_monitor_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + media/device_monitors/device_monitor_udev.h View 4 chunks +5 lines, -5 lines 0 comments Download
A + media/device_monitors/device_monitor_udev.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/device_monitors/system_message_window_win.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + media/device_monitors/system_message_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/device_monitors/system_message_window_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (15 generated)
mcasas
sandersd@ PTAL
4 years, 4 months ago (2016-08-05 22:08:00 UTC) #2
sandersd (OOO until July 31)
lgtm Only question I have is whether there should in fact be a BUILD.gn in ...
4 years, 4 months ago (2016-08-08 19:57:28 UTC) #3
mcasas
On 2016/08/08 19:57:28, sandersd wrote: > lgtm > > Only question I have is whether ...
4 years, 4 months ago (2016-08-09 15:56:10 UTC) #4
mcasas
avi@ content/ changes please
4 years, 4 months ago (2016-08-09 15:56:27 UTC) #6
mcasas
nick@ can you RS the tiny changes in content/browser plz? Thanks
4 years, 4 months ago (2016-08-10 14:36:15 UTC) #8
Avi (use Gerrit)
content lgtm
4 years, 4 months ago (2016-08-10 15:13:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224643002/1
4 years, 4 months ago (2016-08-10 15:52:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/49621)
4 years, 4 months ago (2016-08-10 15:56:06 UTC) #13
ncarter (slow)
avi's lgtm of content lgtm
4 years, 4 months ago (2016-08-10 16:59:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224643002/1
4 years, 4 months ago (2016-08-10 18:34:24 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/120025)
4 years, 4 months ago (2016-08-10 20:34:21 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224643002/1
4 years, 4 months ago (2016-08-10 21:05:34 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 23:29:28 UTC) #27
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 23:32:04 UTC) #29
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c41614771c0e7efac7971738c81d05118cc31709
Cr-Commit-Position: refs/heads/master@{#411181}

Powered by Google App Engine
This is Rietveld 408576698