Add CPDF_ImageObject::GetImage().

Add CPDF_ImageObject::GetImage().

And use it where appropriate.

Committed: https://pdfium.googlesource.com/pdfium/+/f41d9dc1ead47a1218e1cd37bd74ec850c8baaa3

[Lei Zhang, 2016-08-05 20:46:16]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 20:46:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 20:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 20:57:09]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-05 21:02:44]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 21:02:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-05 21:04:42]

thestig@chromium.org changed reviewers:
+ weili@chromium.org

[Lei Zhang, 2016-08-05 21:04:43]

I wanted to try to make CPDF_ImageObject's m_pImage member private in the bug
545 CL, but then it got hairy. So splitting that out separately here. The member
stays public until I can fix all the setters.

[commit-bot: I haz the power, 2016-08-05 21:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 21:57:10]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-05 22:58:21]

lgtm

https://codereview.chromium.org/2224623002/diff/20001/core/fpdfapi/fpdf_rende...
File core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/2224623002/diff/20001/core/fpdfapi/fpdf_rende...
core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:1524: void
CPDF_ImageLoaderHandle::HandleFailureWithCache() {
Use HandleFailure(bool cached) to reduce to one function?

[Lei Zhang, 2016-08-06 05:00:58]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-06 05:01:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 05:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 05:23:53]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-06 05:34:25]

https://codereview.chromium.org/2224623002/diff/20001/core/fpdfapi/fpdf_rende...
File core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/2224623002/diff/20001/core/fpdfapi/fpdf_rende...
core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:1524: void
CPDF_ImageLoaderHandle::HandleFailureWithCache() {
On 2016/08/05 22:58:21, Wei Li wrote:
> Use HandleFailure(bool cached) to reduce to one function?

Done.

[Lei Zhang, 2016-08-06 05:34:30]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-08-06 05:34:31]

The patchset sent to the CQ was uploaded after l-g-t-m from weili@chromium.org
Link to the patchset: https://codereview.chromium.org/2224623002/#ps40001
(title: "merge failure handlers")

[commit-bot: I haz the power, 2016-08-06 05:34:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 05:35:02]

Description was changed from

==========
Add CPDF_ImageObject::GetImage().

And use it where appropriate.
==========

to

==========
Add CPDF_ImageObject::GetImage().

And use it where appropriate.

Committed:
https://pdfium.googlesource.com/pdfium/+/f41d9dc1ead47a1218e1cd37bd74ec850c8b...
==========

[commit-bot: I haz the power, 2016-08-06 05:35:02]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/f41d9dc1ead47a1218e1cd37bd74ec850c8b...