chrome/browser/resources/settings/controls/settings_dropdown_menu.js - Issue 2224613003: Switch MD Settings to paper-dropdown-menu-light

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.js

Issue 2224613003: Switch MD Settings to paper-dropdown-menu-light (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RollPaperDropdown

Patch Set: rebase on loading fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/controls/settings_dropdown_menu.html ('k') | chrome/browser/resources/settings/device_page/display.html » ('j') | chrome/browser/resources/settings/settings_shared_css.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.js

diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.js b/chrome/browser/resources/settings/controls/settings_dropdown_menu.js

index 2982d7c2e2372ca9022c9a5a2ad42e600da09388..b7cfb489e66bc1cd1c0679d56f4501bd8eae1ef9 100644

--- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.js

+++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.js

@@ -96,7 +96,8 @@ Polymer({

if (!this.menuOptions.length)

return;

- this.menuLabel_ = this.label;

+ // Do not set |menuLabel_| to a falsy value: http://goo.gl/OnKYko.

dschuyler 2016/08/11 23:35:26 Please also mention paper-dropdown-menu issue #181

michaelpg 2016/08/16 23:50:43 Done. Although.... nevermind.

+ this.menuLabel_ = this.label || ' ';

this.updateSelected_();