Validate the page title in engine browser test

Validate the page title in engine browser test.

Prior to this change, the engine browser test would only make
asssertions that the URL was changing and that the RenderWidget was
being created. Validating the page title is an easy way to make sure the
intended page is actually the one being sent.

BUG=628324
Committed: https://crrev.com/e4e2ca8a4c6465933a4321ac90200b089cdbc854
Cr-Commit-Position: refs/heads/master@{#410398}

[Brian Goldman, 2016-08-05 19:42:14]

Description was changed from

==========
Validate the page title in engine browser test.

Prior to this change, the engine browser test would only make
asssertions that the URL was changing and that the RenderWidget was
being created. Validating the page title is an easy way to make sure the
intended page is actually the one being sent.

BUG=628324
==========

to

==========
Validate the page title in engine browser test.

Prior to this change, the engine browser test would only make
asssertions that the URL was changing and that the RenderWidget was
being created. Validating the page title is an easy way to make sure the
intended page is actually the one being sent.

BUG=628324
==========

[Brian Goldman, 2016-08-05 19:42:15]

bgoldman@chromium.org changed reviewers:
+ kmarshall@chromium.org, sriramsr@chromium.org

[Kevin M, 2016-08-05 23:30:17]

lgtm

https://codereview.chromium.org/2224613002/diff/1/blimp/engine/browser_tests/...
File blimp/engine/browser_tests/engine_browsertest.cc (right):

https://codereview.chromium.org/2224613002/diff/1/blimp/engine/browser_tests/...
blimp/engine/browser_tests/engine_browsertest.cc:61:
IN_PROC_BROWSER_TEST_F(EngineBrowserTest, LoadUrl) {
Consider adding a "testing::InSequence s" here to validate that the title
changes are happening in the exact specified order.

[Brian Goldman, 2016-08-06 17:21:14]

https://codereview.chromium.org/2224613002/diff/1/blimp/engine/browser_tests/...
File blimp/engine/browser_tests/engine_browsertest.cc (right):

https://codereview.chromium.org/2224613002/diff/1/blimp/engine/browser_tests/...
blimp/engine/browser_tests/engine_browsertest.cc:61:
IN_PROC_BROWSER_TEST_F(EngineBrowserTest, LoadUrl) {
On 2016/08/05 23:30:17, Kevin M wrote:
> Consider adding a "testing::InSequence s" here to validate that the title
> changes are happening in the exact specified order.

Done.

[Kevin M, 2016-08-08 17:45:23]

The CQ bit was checked by kmarshall@chromium.org

[Kevin M, 2016-08-08 17:45:24]

lgtm

[commit-bot: I haz the power, 2016-08-08 17:45:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 18:20:18]

Description was changed from

==========
Validate the page title in engine browser test.

Prior to this change, the engine browser test would only make
asssertions that the URL was changing and that the RenderWidget was
being created. Validating the page title is an easy way to make sure the
intended page is actually the one being sent.

BUG=628324
==========

to

==========
Validate the page title in engine browser test.

Prior to this change, the engine browser test would only make
asssertions that the URL was changing and that the RenderWidget was
being created. Validating the page title is an easy way to make sure the
intended page is actually the one being sent.

BUG=628324
==========

[commit-bot: I haz the power, 2016-08-08 18:20:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 18:22:30]

Description was changed from

==========
Validate the page title in engine browser test.

Prior to this change, the engine browser test would only make
asssertions that the URL was changing and that the RenderWidget was
being created. Validating the page title is an easy way to make sure the
intended page is actually the one being sent.

BUG=628324
==========

to

==========
Validate the page title in engine browser test.

Prior to this change, the engine browser test would only make
asssertions that the URL was changing and that the RenderWidget was
being created. Validating the page title is an easy way to make sure the
intended page is actually the one being sent.

BUG=628324

Committed: https://crrev.com/e4e2ca8a4c6465933a4321ac90200b089cdbc854
Cr-Commit-Position: refs/heads/master@{#410398}
==========

[commit-bot: I haz the power, 2016-08-08 18:22:32]

Patchset 2 (id:??) landed as
https://crrev.com/e4e2ca8a4c6465933a4321ac90200b089cdbc854
Cr-Commit-Position: refs/heads/master@{#410398}