Don't analyze scopes outside of the compiled scope

Don't analyze scopes outside of the compiled scope

The outer scope of the scope we are compiling doesn't need analysis. Either we're compiling top-level code in which case there is no outer scope. Or we are compiling code at the top-level (eval, function, module), and there won't be anything to resolve in the outer scope. Lastly we could also be compiling with a deserialized scope. In that case the outer scope is already resolved.

BUG=v8:5209
Committed: https://crrev.com/0c699a581917d6c499e0f55eff349060ff1a474b
Cr-Commit-Position: refs/heads/master@{#38419}

[Toon Verwaest, 2016-08-05 19:03:14]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 19:03:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Toon Verwaest, 2016-08-05 19:06:56]

verwaest@chromium.org changed reviewers:
+ adamk@chromium.org

[Toon Verwaest, 2016-08-05 19:06:57]

ptal. I think this should hold; and our tests don't disagree, wdyt?

[commit-bot: I haz the power, 2016-08-05 19:27:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 19:27:32]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-08-05 20:13:43]

adamk@chromium.org changed reviewers:
+ bradnelson@chromium.org

[adamk, 2016-08-05 20:13:44]

I agree that this is correct for variable analysis, but I haven't yet convinced
myself it's true for PropagateScopeInfo, specifically the
asm_module_/asm_function_ logic. I'm not sure how/whether that's covered by
tests. I think titzer's on vacation, adding bradnelson in case he knows.

lgtm % that worry

[Toon Verwaest, 2016-08-05 20:56:45]

Description was changed from

==========
Don't analyze scopes outside of the compiled scope

The outer scope of the scope we are compiling doesn't need analysis. Either
we're compiling top-level code in which case there is no outer scope. Or we are
compiling code at the top-level (eval, function, module), and there won't be
anything to resolve in the outer scope. Lastly we could also be compiling with a
deserialized scope. In that case the outer scope is already resolved.

BUG=v8:520
==========

to

==========
Don't analyze scopes outside of the compiled scope

The outer scope of the scope we are compiling doesn't need analysis. Either
we're compiling top-level code in which case there is no outer scope. Or we are
compiling code at the top-level (eval, function, module), and there won't be
anything to resolve in the outer scope. Lastly we could also be compiling with a
deserialized scope. In that case the outer scope is already resolved.

BUG=v8:5209
==========

[bradnelson, 2016-08-07 03:05:24]

lgtm

https://codereview.chromium.org/2224593002/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2224593002/diff/1/src/ast/scopes.cc#newcode383
src/ast/scopes.cc:383: // 3) a function/eval in a scope that was already
resolved.
You can also be compiling the text of an Asm.js module passed to
WASM.instantiateModuleFromAsm()
However, this will go away pretty soon.
Got some changes in the works.

[Toon Verwaest, 2016-08-08 08:27:08]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-08-08 08:27:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 08:47:52]

Description was changed from

==========
Don't analyze scopes outside of the compiled scope

The outer scope of the scope we are compiling doesn't need analysis. Either
we're compiling top-level code in which case there is no outer scope. Or we are
compiling code at the top-level (eval, function, module), and there won't be
anything to resolve in the outer scope. Lastly we could also be compiling with a
deserialized scope. In that case the outer scope is already resolved.

BUG=v8:5209
==========

to

==========
Don't analyze scopes outside of the compiled scope

The outer scope of the scope we are compiling doesn't need analysis. Either
we're compiling top-level code in which case there is no outer scope. Or we are
compiling code at the top-level (eval, function, module), and there won't be
anything to resolve in the outer scope. Lastly we could also be compiling with a
deserialized scope. In that case the outer scope is already resolved.

BUG=v8:5209
==========

[commit-bot: I haz the power, 2016-08-08 08:47:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-08 08:48:47]

Description was changed from

==========
Don't analyze scopes outside of the compiled scope

The outer scope of the scope we are compiling doesn't need analysis. Either
we're compiling top-level code in which case there is no outer scope. Or we are
compiling code at the top-level (eval, function, module), and there won't be
anything to resolve in the outer scope. Lastly we could also be compiling with a
deserialized scope. In that case the outer scope is already resolved.

BUG=v8:5209
==========

to

==========
Don't analyze scopes outside of the compiled scope

The outer scope of the scope we are compiling doesn't need analysis. Either
we're compiling top-level code in which case there is no outer scope. Or we are
compiling code at the top-level (eval, function, module), and there won't be
anything to resolve in the outer scope. Lastly we could also be compiling with a
deserialized scope. In that case the outer scope is already resolved.

BUG=v8:5209

Committed: https://crrev.com/0c699a581917d6c499e0f55eff349060ff1a474b
Cr-Commit-Position: refs/heads/master@{#38419}
==========

[commit-bot: I haz the power, 2016-08-08 08:48:48]

Patchset 1 (id:??) landed as
https://crrev.com/0c699a581917d6c499e0f55eff349060ff1a474b
Cr-Commit-Position: refs/heads/master@{#38419}