Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 2224583004: Explicitly list content of generated .dSYM directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@{}
Patch Set: Convert dsym_output variable to a list to avoid repetition. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/rules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index dea16ebbcabc9158125d2175cd8ea41d5cb1e0b3..d3b0eeba68e0fb9a189aaec3a8e2005096f30b79 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -114,8 +114,14 @@ template("mac_toolchain") {
# If dSYMs are enabled, this flag will be added to the link tools.
if (_enable_dsyms) {
dsym_switch = " -Wcrl,dsym,{{root_out_dir}} "
- _dsym_output =
- "{{root_out_dir}}/{{target_output_name}}{{output_extension}}.dSYM/"
+ dsym_output_dir =
+ "{{root_out_dir}}/{{target_output_name}}{{output_extension}}.dSYM"
+ dsym_output = [
+ "$dsym_output_dir/",
+ "$dsym_output_dir/Contents/Info.plist",
+ "$dsym_output_dir/Contents/Resources/DWARF/" +
+ "{{target_output_name}}{{output_extension}}",
+ ]
} else {
dsym_switch = ""
}
@@ -249,7 +255,7 @@ template("mac_toolchain") {
depend_output = tocname
if (_enable_dsyms) {
- outputs += [ _dsym_output ]
+ outputs += dsym_output
}
if (_save_unstripped_output) {
outputs += [ _unstripped_output ]
@@ -284,7 +290,7 @@ template("mac_toolchain") {
]
if (_enable_dsyms) {
- outputs += [ _dsym_output ]
+ outputs += dsym_output
}
if (_save_unstripped_output) {
outputs += [ _unstripped_output ]
@@ -312,7 +318,7 @@ template("mac_toolchain") {
]
if (_enable_dsyms) {
- outputs += [ _dsym_output ]
+ outputs += dsym_output
}
if (_save_unstripped_output) {
outputs += [ _unstripped_output ]
« no previous file with comments | « build/config/ios/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698