Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2224523002: Disable connection migration in cronet tests (Closed)

Created:
4 years, 4 months ago by mgersh
Modified:
4 years, 4 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable connection migration in cronet tests It doesn't work on test devices with no network access. Disabling it so the new bots will turn green. BUG=634910 Committed: https://crrev.com/3faae2e8a5f336edcc8dd09b01655db8fbd0edbc Cr-Commit-Position: refs/heads/master@{#410116}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mgersh
PTAL
4 years, 4 months ago (2016-08-05 17:44:12 UTC) #2
xunjieli
lgtm
4 years, 4 months ago (2016-08-05 17:45:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224523002/1
4 years, 4 months ago (2016-08-05 17:48:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 18:24:45 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 18:27:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3faae2e8a5f336edcc8dd09b01655db8fbd0edbc
Cr-Commit-Position: refs/heads/master@{#410116}

Powered by Google App Engine
This is Rietveld 408576698