Add support for loading API keys from Info.plist on iOS and macOS.

google_apis/google_api_keys_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit tests for implementation of google_api_keys namespace.
 //
 // Because the file deals with a lot of preprocessor defines and
 // optionally includes an internal header, the way we test is by
 // including the .cc file multiple times with different defines set.
 // This is a little unorthodox, but it lets us test the behavior as
@@ skipping 24 matching lines @@
 // from that file included here is the "right" version.
 
 #include <stddef.h>
 
 #include <string>
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/strings/stringize_macros.h"
+#include "google_apis/google_api_keys_mac.h"

[Roger Tawa OOO till Jul 10th, 2016/08/08 18:03:05]

Should this be in an #ifdef?

[bzanotti, 2016/08/10 13:23:40]

Yes, this unit test is ran on Linux as well where it makes no sense to include
this header. Done.

 
 // This is the default baked-in value for OAuth IDs and secrets.
 static const char kDummyToken[] = "dummytoken";
 
 struct EnvironmentCache {
  public:
   EnvironmentCache() : variable_name(NULL), was_set(false) {}
 
   const char* variable_name;
   bool was_set;
@@ skipping 43 matching lines @@
  private:
   std::unique_ptr<base::Environment> env_;
 
   // Why 3?  It is for GOOGLE_API_KEY, GOOGLE_DEFAULT_CLIENT_ID and
   // GOOGLE_DEFAULT_CLIENT_SECRET.
   //
   // Why 2 times CLIENT_NUM_ITEMS?  This is the number of different
   // clients in the OAuth2Client enumeration, and for each of these we
   // have both an ID and a secret.
   EnvironmentCache env_cache_[3 + 2 * google_apis::CLIENT_NUM_ITEMS];
 };

[Roger Tawa OOO till Jul 10th, 2016/08/08 18:03:05]

There seems to be lots of duplicate code here with
google_api_keys_mac_unittest.mm.  Can we refactor this into common code?

[bzanotti, 2016/08/10 13:23:40]

Done.

 
 #if defined(GOOGLE_CHROME_BUILD) || defined(USE_OFFICIAL_GOOGLE_API_KEYS)
 // Test official build behavior, since we are in a checkout where this
 // is possible.
 namespace official_build {
 
 // We start every test by creating a clean environment for the
 // preprocessor defines used in google_api_keys.cc
 #undef DUMMY_API_TOKEN
 #undef GOOGLE_API_KEY
@@ skipping 375 matching lines @@
   EXPECT_EQ("env-SECRET_MAIN", secret_main);
   EXPECT_EQ("env-ID_CLOUD_PRINT", id_cloud_print);
   EXPECT_EQ("env-SECRET_CLOUD_PRINT", secret_cloud_print);
   EXPECT_EQ("env-ID_REMOTING", id_remoting);
   EXPECT_EQ("env-SECRET_REMOTING", secret_remoting);
   EXPECT_EQ("env-ID_REMOTING_HOST", id_remoting_host);
   EXPECT_EQ("env-SECRET_REMOTING_HOST", secret_remoting_host);
 }
 
 #endif  // defined(OS_LINUX) || defined(OS_MACOSX)