DevTools: Treat system object distances with less priority

Source/devtools/front_end/HeapSnapshot.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 917 matching lines @@
  */
 function HeapSnapshotHeader()
 {
     // New format.
     this.title = "";
     this.meta = new HeapSnapshotMetainfo();
     this.node_count = 0;
     this.edge_count = 0;
 }
 
+WebInspector.HeapSnapshot._baseSystemDistance = 100000000;

[yurys, 2014/04/03 09:15:12]

You can place this constant into HeapSnapshotCommon instead.

[alph, 2014/04/03 09:30:48]

Done.

+
 WebInspector.HeapSnapshot.prototype = {
     _init: function()
     {
         var meta = this._metaNode;
 
         this._nodeTypeOffset = meta.node_fields.indexOf("type");
         this._nodeNameOffset = meta.node_fields.indexOf("name");
         this._nodeIdOffset = meta.node_fields.indexOf("id");
         this._nodeSelfSizeOffset = meta.node_fields.indexOf("self_size");
         this._nodeEdgeCountOffset = meta.node_fields.indexOf("edge_count");
@@ skipping 374 matching lines @@
                 return;
             distances[ordinal] = distance;
             nodesToVisit[nodesToVisitLength++] = node.nodeIndex;
         }
 
         this.forEachRoot(enqueueNode.bind(null, 1), true);
         this._bfs(nodesToVisit, nodesToVisitLength, distances);
 
         // bfs for the rest of objects
         nodesToVisitLength = 0;
-        this.forEachRoot(enqueueNode.bind(null, 0), false);
+        this.forEachRoot(enqueueNode.bind(null, WebInspector.HeapSnapshot._baseSystemDistance), false);
         this._bfs(nodesToVisit, nodesToVisitLength, distances);
     },
 
     /**
      * @param {!Uint32Array} nodesToVisit
      * @param {!number} nodesToVisitLength
      * @param {!Int32Array} distances
      */
     _bfs: function(nodesToVisit, nodesToVisitLength, distances)
     {
@@ skipping 693 matching lines @@
                 id = nextId;
         }
         return id;
     },
 
     /**
      * @return {!WebInspector.HeapSnapshotCommon.StaticData}
      */
     updateStaticData: function()
     {
-        return new WebInspector.HeapSnapshotCommon.StaticData(this.nodeCount, this._rootNodeIndex, this.totalSize, this._maxJsNodeId());
+        return new WebInspector.HeapSnapshotCommon.StaticData(
+            this.nodeCount,
+            this._rootNodeIndex,
+            this.totalSize,
+            this._maxJsNodeId(),
+            WebInspector.HeapSnapshot._baseSystemDistance);
     }
 };
 
 /**
  * @constructor
  * @param {!WebInspector.HeapSnapshotItemIterator} iterator
  * @param {!WebInspector.HeapSnapshotItemIndexProvider} indexProvider
  */
 WebInspector.HeapSnapshotItemProvider = function(iterator, indexProvider)
 {
@@ skipping 254 matching lines @@
      * @param {number} windowRight
      */
     sort: function(comparator, leftBound, rightBound, windowLeft, windowRight)
     {
         this._iterationOrder.sortRange(this._buildCompareFunction(comparator), leftBound, rightBound, windowLeft, windowRight);
     },
 
     __proto__: WebInspector.HeapSnapshotItemProvider.prototype
 }