Issue 222443003: DevTools: Treat system object distances with less priority

Issue 222443003: DevTools: Treat system object distances with less priority (Closed)

Created:
6 years, 8 months ago by alph

Modified:
6 years, 8 months ago

Reviewers:
yurys, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Treat system object distances with less priority Currently if a user object is retained by both a system-space object (e.g. a debugger) and another user object, the system object might be shown earlier in the retainers tree. This happens if its distance is smaller than distances of other retaining user objects. The patch treats links from system-space objects to user objects with less priority, so these links are shown at the bottom of the retainers tree. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170765

Patch Set 1 #

Total comments: 2

Patch Set 2 : Do not show system distance #

Patch Set 3 : Addressing comments. #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -7 lines)			Patch
M	LayoutTests/inspector/profiler/heap-snapshot-containment-show-all.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/HeapSnapshot.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/HeapSnapshotCommon.js	View	1 2	2 chunks	+3 lines, -1 line	1 comment	Download
M	Source/devtools/front_end/HeapSnapshotGridNodes.js	View	1 2	3 chunks	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

yurys

This is still confusing as we keep showing to different distances in the same column. ...

6 years, 8 months ago (2014-04-03 09:15:12 UTC) #2

alph

done. ptal https://codereview.chromium.org/222443003/diff/1/Source/devtools/front_end/HeapSnapshot.js File Source/devtools/front_end/HeapSnapshot.js (right): https://codereview.chromium.org/222443003/diff/1/Source/devtools/front_end/HeapSnapshot.js#newcode938 Source/devtools/front_end/HeapSnapshot.js:938: WebInspector.HeapSnapshot._baseSystemDistance = 100000000; On 2014/04/03 09:15:12, yurys ...

6 years, 8 months ago (2014-04-03 09:30:47 UTC) #3

yurys

lgtm https://codereview.chromium.org/222443003/diff/40001/Source/devtools/front_end/HeapSnapshotCommon.js File Source/devtools/front_end/HeapSnapshotCommon.js (right): https://codereview.chromium.org/222443003/diff/40001/Source/devtools/front_end/HeapSnapshotCommon.js#newcode38 Source/devtools/front_end/HeapSnapshotCommon.js:38: WebInspector.HeapSnapshotCommon.baseSystemDistance = 100000000; heapRootDistance

6 years, 8 months ago (2014-04-03 09:34:20 UTC) #4

alph

On 2014/04/03 09:34:20, yurys wrote: > lgtm > > https://codereview.chromium.org/222443003/diff/40001/Source/devtools/front_end/HeapSnapshotCommon.js > File Source/devtools/front_end/HeapSnapshotCommon.js (right): > ...

6 years, 8 months ago (2014-04-03 09:37:46 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/222443003/40001

6 years, 8 months ago (2014-04-03 09:38:00 UTC) #7

Message was sent while issue was closed.

Change committed as 170765

Expand Messages | Collapse Messages