Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2224423002: Revert of Add sync_unit_tests to the default test suite on iOS. (Closed)

Created:
4 years, 4 months ago by sdefresne
Modified:
4 years, 4 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add sync_unit_tests to the default test suite on iOS. (patchset #1 id:1 of https://codereview.chromium.org/2224233002/ ) Reason for revert: sync_unit_tests is a stub that should no longer be build nor run on the bots, reverting after discussion with maxbogue. Original issue's description: > Add sync_unit_tests to the default test suite on iOS. > > This test is part of the default downstream test suite on iOS so > add it to the default upstream test suite too. > > BUG=None > > Committed: https://crrev.com/72865779ebbb3524a76bc36f7a0c356d39d543a8 > Cr-Commit-Position: refs/heads/master@{#410571} TBR=kkhorimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/c76b4b6c3b21025e4c32124e1ceedd637e34cdf7 Cr-Commit-Position: refs/heads/master@{#410787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ios/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/build/bots/tests/common_tests.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sdefresne
Created Revert of Add sync_unit_tests to the default test suite on iOS.
4 years, 4 months ago (2016-08-09 20:09:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224423002/1
4 years, 4 months ago (2016-08-09 20:10:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 20:11:14 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 20:13:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c76b4b6c3b21025e4c32124e1ceedd637e34cdf7
Cr-Commit-Position: refs/heads/master@{#410787}

Powered by Google App Engine
This is Rietveld 408576698