Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2224413002: Presubmit recipe: rebase Gerrit patches. (Closed)

Created:
4 years, 4 months ago by tandrii(chromium)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Presubmit recipe: rebase Gerrit patches. Make use of gerrit_rebase_patch_ref property in bot_update. Depends on https://chromium-review.googlesource.com/c/365990. BUG=612417 R=andybons@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/52b73ce928346e5ff2de78658eed76bf048b1d45

Patch Set 1 #

Patch Set 2 : add expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M scripts/slave/recipes/run_presubmit.py View 2 chunks +6 lines, -2 lines 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json View 1 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks_and_gerrit.json View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
tandrii(chromium)
4 years, 4 months ago (2016-08-09 19:27:58 UTC) #1
Bons
lgtm
4 years, 4 months ago (2016-08-09 19:51:11 UTC) #8
Sergiy Byelozyorov
lgtm
4 years, 4 months ago (2016-08-09 19:53:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224413002/20001
4 years, 4 months ago (2016-08-09 19:53:17 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 19:57:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/52b73ce928346e5ff2de...

Powered by Google App Engine
This is Rietveld 408576698