mojo/public/tools/bindings/chromium_bindings_configuration.gni - Issue 2224343003: GN: Throw an error overwriting a nonempty scope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/chromium_bindings_configuration.gni

Issue 2224343003: GN: Throw an error overwriting a nonempty scope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/chromium_bindings_configuration.gni

diff --git a/mojo/public/tools/bindings/chromium_bindings_configuration.gni b/mojo/public/tools/bindings/chromium_bindings_configuration.gni

index 3ab0bd73421a2661c1442adc1e430f5492ca107d..032b0c17f62032240a99588f455e144be3cd804a 100644

--- a/mojo/public/tools/bindings/chromium_bindings_configuration.gni

+++ b/mojo/public/tools/bindings/chromium_bindings_configuration.gni

@@ -23,6 +23,9 @@ _typemap_imports = [

_typemaps = []

foreach(typemap_import, _typemap_imports) {

+ # Avoid reassignment error by assigning to empty scope first.

+ _imported = {

+ }

_imported = read_file(typemap_import, "scope")

_typemaps += _imported.typemaps

}