Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Side by Side Diff: mojo/public/tools/bindings/blink_bindings_configuration.gni

Issue 2224343003: GN: Throw an error overwriting a nonempty scope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 variant = "blink" 5 variant = "blink"
6 6
7 for_blink = true 7 for_blink = true
8 8
9 _typemap_imports = [ 9 _typemap_imports = [
10 "//mojo/public/cpp/bindings/tests/blink_typemaps.gni", 10 "//mojo/public/cpp/bindings/tests/blink_typemaps.gni",
11 "//third_party/WebKit/Source/platform/mojo/blink_typemaps.gni", 11 "//third_party/WebKit/Source/platform/mojo/blink_typemaps.gni",
12 "//third_party/WebKit/public/blink_typemaps.gni", 12 "//third_party/WebKit/public/blink_typemaps.gni",
13 ] 13 ]
14 _typemaps = [] 14 _typemaps = []
15 15
16 foreach(typemap_import, _typemap_imports) { 16 foreach(typemap_import, _typemap_imports) {
17 # Avoid reassignment error by assigning to empty scope first.
18 _imported = {
19 }
17 _imported = read_file(typemap_import, "scope") 20 _imported = read_file(typemap_import, "scope")
18 _typemaps += _imported.typemaps 21 _typemaps += _imported.typemaps
19 } 22 }
20 23
21 typemaps = [] 24 typemaps = []
22 foreach(typemap, _typemaps) { 25 foreach(typemap, _typemaps) {
23 typemaps += [ read_file(typemap, "scope") ] 26 typemaps += [ read_file(typemap, "scope") ]
24 } 27 }
25 28
26 blacklist = [ 29 blacklist = [
27 # TODO(sammc): Remove the following once |for_blink| bindings support WTF 30 # TODO(sammc): Remove the following once |for_blink| bindings support WTF
28 # maps with enum keys. See https://crbug.com/583738. 31 # maps with enum keys. See https://crbug.com/583738.
29 "//mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom", 32 "//mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom",
30 ] 33 ]
OLDNEW
« no previous file with comments | « no previous file | mojo/public/tools/bindings/chromium_bindings_configuration.gni » ('j') | tools/gn/operators.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698