Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 2224343002: [interpreter] Collect type feedback in Add, Mul, Div and Mod. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/code-stubs.cc ('K') | « src/code-stubs.cc ('k') | src/globals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/bytecode-graph-builder.cc
diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc
index 08036639c0196c6c3c611f5a95fe32d12521dad9..c3bd48e16a90611fbb974d8f61c0581e778ac4f1 100644
--- a/src/compiler/bytecode-graph-builder.cc
+++ b/src/compiler/bytecode-graph-builder.cc
@@ -1185,8 +1185,7 @@ BinaryOperationHints BytecodeGraphBuilder::GetBinaryOperationHint() {
}
void BytecodeGraphBuilder::VisitAdd() {
- BinaryOperationHints hints = BinaryOperationHints::Any();
- BuildBinaryOp(javascript()->Add(hints));
+ BuildBinaryOp(javascript()->Add(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitSub() {
@@ -1194,18 +1193,15 @@ void BytecodeGraphBuilder::VisitSub() {
}
void BytecodeGraphBuilder::VisitMul() {
- BinaryOperationHints hints = BinaryOperationHints::Any();
- BuildBinaryOp(javascript()->Multiply(hints));
+ BuildBinaryOp(javascript()->Multiply(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitDiv() {
- BinaryOperationHints hints = BinaryOperationHints::Any();
- BuildBinaryOp(javascript()->Divide(hints));
+ BuildBinaryOp(javascript()->Divide(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitMod() {
- BinaryOperationHints hints = BinaryOperationHints::Any();
- BuildBinaryOp(javascript()->Modulus(hints));
+ BuildBinaryOp(javascript()->Modulus(GetBinaryOperationHint()));
}
void BytecodeGraphBuilder::VisitBitwiseOr() {
« src/code-stubs.cc ('K') | « src/code-stubs.cc ('k') | src/globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698