[interpreter] Collect type feedback in Add, Mul, Div and Mod.

[interpreter] Collect type feedback in Add, Mul, Div and Mod.

Introduces code stubs to collect type feedback for the Add, Mul, Div and Mod operations in the interpreter, and modifies the BytecodeGraphBuilder to make use of it.

BUG=v8:5273
LOG=N

Committed: https://crrev.com/63516a8c60f696bc942b73c1835a51d9c066945e
Cr-Commit-Position: refs/heads/master@{#38543}

[epertoso, 2016-08-09 13:37:18]

Description was changed from

==========
[interpreter] Collect type feedback in Add, Mul, Div and Mod.

Introduces code stubs to collect type feedback for the Add, Mul, Div and Mod
operations in the interpreter, and modifies the BytecodeGraphBuilder to make use
of it.

BUG=v8:5273
LOG=N
==========

to

==========
[interpreter] Collect type feedback in Add, Mul, Div and Mod.

Introduces code stubs to collect type feedback for the Add, Mul, Div and Mod
operations in the interpreter, and modifies the BytecodeGraphBuilder to make use
of it.

BUG=v8:5273
LOG=N
==========

[epertoso, 2016-08-09 13:37:18]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[epertoso, 2016-08-09 13:37:18]

epertoso@chromium.org changed required reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[epertoso, 2016-08-09 13:58:49]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 13:58:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 14:34:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 14:34:49]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/12179)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[rmcilroy, 2016-08-09 14:59:50]

LGTM assuming Benedikt is happy, thanks.

https://codereview.chromium.org/2224343002/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/2224343002/diff/1/src/code-stubs.cc#newcode1878
src/code-stubs.cc:1878: // Do floating point division {dividend} is zero and
{divisor} is
"division {dividend}" -> "division if {dividend}"

[Benedikt Meurer, 2016-08-09 18:34:11]

LGTM, thanks.

[epertoso, 2016-08-10 10:25:30]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-08-10 10:25:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2224343002/#ps20001
(title: "Update.")

[commit-bot: I haz the power, 2016-08-10 10:25:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 10:53:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 10:53:38]

Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/10711)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[epertoso, 2016-08-10 14:06:32]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-08-10 14:06:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2224343002/#ps40001
(title: "Fixes test-interpreter/InterpreterParameter8.")

[commit-bot: I haz the power, 2016-08-10 14:06:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 14:33:45]

Description was changed from

==========
[interpreter] Collect type feedback in Add, Mul, Div and Mod.

Introduces code stubs to collect type feedback for the Add, Mul, Div and Mod
operations in the interpreter, and modifies the BytecodeGraphBuilder to make use
of it.

BUG=v8:5273
LOG=N
==========

to

==========
[interpreter] Collect type feedback in Add, Mul, Div and Mod.

Introduces code stubs to collect type feedback for the Add, Mul, Div and Mod
operations in the interpreter, and modifies the BytecodeGraphBuilder to make use
of it.

BUG=v8:5273
LOG=N
==========

[commit-bot: I haz the power, 2016-08-10 14:33:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-10 14:34:05]

Description was changed from

==========
[interpreter] Collect type feedback in Add, Mul, Div and Mod.

Introduces code stubs to collect type feedback for the Add, Mul, Div and Mod
operations in the interpreter, and modifies the BytecodeGraphBuilder to make use
of it.

BUG=v8:5273
LOG=N
==========

to

==========
[interpreter] Collect type feedback in Add, Mul, Div and Mod.

Introduces code stubs to collect type feedback for the Add, Mul, Div and Mod
operations in the interpreter, and modifies the BytecodeGraphBuilder to make use
of it.

BUG=v8:5273
LOG=N

Committed: https://crrev.com/63516a8c60f696bc942b73c1835a51d9c066945e
Cr-Commit-Position: refs/heads/master@{#38543}
==========

[commit-bot: I haz the power, 2016-08-10 14:34:06]

Patchset 3 (id:??) landed as
https://crrev.com/63516a8c60f696bc942b73c1835a51d9c066945e
Cr-Commit-Position: refs/heads/master@{#38543}