Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 222433003: Fix crash in isDocumentDoneLoading() (Closed)

Created:
6 years, 8 months ago by Nate Chapin
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Fix crash in isDocumentDoneLoading() Document::loader() might be null if re-entrancy is involved. BUG=357570 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/loader/FrameLoader.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nate Chapin
No test, because all I have to go on is a stack trace that involves ...
6 years, 8 months ago (2014-04-02 17:33:54 UTC) #1
abarth-chromium
lgtm ok
6 years, 8 months ago (2014-04-02 18:49:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/222433003/1
6 years, 8 months ago (2014-04-02 18:49:31 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 19:52:51 UTC) #4
Message was sent while issue was closed.
Change committed as 170693

Powered by Google App Engine
This is Rietveld 408576698