chrome/browser/chromeos/drive/search_metadata.cc - Issue 22243002: GTTF: Enable glibcxx debug mode for Debug builds by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/search_metadata.cc

Issue 22243002: GTTF: Enable glibcxx debug mode for Debug builds by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/drive/search_metadata.cc

diff --git a/chrome/browser/chromeos/drive/search_metadata.cc b/chrome/browser/chromeos/drive/search_metadata.cc

index 2e4a1d690a691c8eae6c1951adbddcd3611a1302..8886356c04eecfa8020742c3dfd06ebf8d39dc00 100644

--- a/chrome/browser/chromeos/drive/search_metadata.cc

+++ b/chrome/browser/chromeos/drive/search_metadata.cc

@@ -78,8 +78,12 @@ class ScopedPriorityQueue {

void push(T* x) { queue_.push(x); }

void pop() {

- delete queue_.top();

+ // Keep top alive for the pop() call so that debug checks can access

+ // underlying data (e.g. validating heap property of the priority queue

+ // will call the comparator).

+ T* saved_top = queue_.top();

queue_.pop();

+ delete saved_top;

}

private:

« no previous file with comments | « build/common.gypi ('k') | chrome/browser/ui/browser_iterator.h » ('j') | no next file with comments »