Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2058)

Unified Diff: build/common.gypi

Issue 22243002: GTTF: Enable glibcxx debug mode for Debug builds by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/values.cc ('k') | chrome/browser/chromeos/drive/search_metadata.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c69e342232aaa92c8ae51e959f0c61ff8cc99166..6df078e5e43da876b8de9f76c4c3474f5ef370cc 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1019,8 +1019,6 @@
# Profile without optimizing out stack frames when profiling==1.
'profiling_full_stack_frames%': '0',
- # Enable strict glibc debug mode.
- 'glibcxx_debug%': 0,
# And if we want to dump symbols for Breakpad-enabled builds.
'linux_dump_symbols%': 0,
# And if we want to strip the binary after dumping symbols.
@@ -2042,10 +2040,6 @@
['profiling==1', {
'defines': ['ENABLE_PROFILING=1'],
}],
- ['OS=="linux" and glibcxx_debug==1', {
- 'defines': ['_GLIBCXX_DEBUG=1',],
- 'cflags_cc+': ['-g'],
- }],
['remoting==1', {
'defines': ['ENABLE_REMOTING=1'],
}],
@@ -2646,6 +2640,13 @@
}],
],
}],
+ ['OS=="linux" and target_arch!="ia32"', {
+ # Enable libstdc++ debugging facilities to help catch problems
+ # early, see http://crbug.com/65151 .
+ # TODO(phajdan.jr): Should we enable this for all of POSIX?
+ 'defines': ['_GLIBCXX_DEBUG=1',],
+ 'cflags_cc+': ['-g'],
Nico 2013/11/06 21:30:42 Shouldn't this (-g) be on for Debug already? Do yo
Lei Zhang 2013/11/06 21:37:31 Probably not, looks like it's just copy + pasted f
Nico 2013/11/06 22:07:47 Then please remove this before landing :-) Thanks
Paweł Hajdan Jr. 2013/11/07 21:05:45 Done.
+ }],
# Disabled on iOS because it was causing a crash on startup.
# TODO(michelea): investigate, create a reduced test and possibly
# submit a radar.
« no previous file with comments | « base/values.cc ('k') | chrome/browser/chromeos/drive/search_metadata.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698