Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2224233002:
Add sync_unit_tests to the default test suite on iOS. (Closed)
|
Created:
4 years, 4 months ago by sdefresne Modified:
4 years, 4 months ago Reviewers:
kkhorimoto CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd sync_unit_tests to the default test suite on iOS.
This test is part of the default downstream test suite on iOS so
add it to the default upstream test suite too.
BUG=None
Committed: https://crrev.com/72865779ebbb3524a76bc36f7a0c356d39d543a8
Cr-Commit-Position: refs/heads/master@{#410571}
Patch Set 1 #
Messages
Total messages: 24 (14 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + kkhorimoto@google.com
PTAL
Description was changed from ========== Add sync_unit_tests to the default test suite on iOS. This test is part of the default downstream test suite on iOS so add it to the default upstream test suite too. BUG=None ========== to ========== Add sync_unit_tests to the default test suite on iOS. This test is part of the default downstream test suite on iOS so add it to the default upstream test suite too. BUG=None ==========
sdefresne@chromium.org changed reviewers: + kkhorimoto@chromium.org - kkhorimoto@google.com
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add sync_unit_tests to the default test suite on iOS. This test is part of the default downstream test suite on iOS so add it to the default upstream test suite too. BUG=None ========== to ========== Add sync_unit_tests to the default test suite on iOS. This test is part of the default downstream test suite on iOS so add it to the default upstream test suite too. BUG=None ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add sync_unit_tests to the default test suite on iOS. This test is part of the default downstream test suite on iOS so add it to the default upstream test suite too. BUG=None ========== to ========== Add sync_unit_tests to the default test suite on iOS. This test is part of the default downstream test suite on iOS so add it to the default upstream test suite too. BUG=None Committed: https://crrev.com/72865779ebbb3524a76bc36f7a0c356d39d543a8 Cr-Commit-Position: refs/heads/master@{#410571} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/72865779ebbb3524a76bc36f7a0c356d39d543a8 Cr-Commit-Position: refs/heads/master@{#410571}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2224423002/ by sdefresne@chromium.org. The reason for reverting is: sync_unit_tests is a stub that should no longer be build nor run on the bots, reverting after discussion with maxbogue.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
