Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2224223002: Combine Physical Web URLs into groups (Closed)

Created:
4 years, 4 months ago by cco3
Modified:
4 years, 4 months ago
Reviewers:
gone, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Combine Physical Web URLs into groups A group id is an identifier that associates URLs into buckets. (i.e., URLs from the same domain with the same title might have the same group id). This change displays groups as a single entry in our display list, and then chooses the closest URL when a user taps the entry. BUG=633715 Committed: https://crrev.com/5ba64b349e320be7a35c42dcdfbdeaea9ae412b3 Cr-Commit-Position: refs/heads/master@{#411724}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make mPwsResults final #

Messages

Total messages: 13 (5 generated)
cco3
Hi Matt, PTAL
4 years, 4 months ago (2016-08-08 23:15:05 UTC) #2
mattreynolds
lgtm, thanks for adding the tests
4 years, 4 months ago (2016-08-09 18:41:49 UTC) #3
cco3
4 years, 4 months ago (2016-08-09 18:44:27 UTC) #5
gone
lgtm https://chromiumcodereview.appspot.com/2224223002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java (right): https://chromiumcodereview.appspot.com/2224223002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java#newcode78 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:78: private List<PwsResult> mPwsResults; private final List<PwsResult> mPwsResults = ...
4 years, 4 months ago (2016-08-10 00:29:18 UTC) #6
cco3
https://codereview.chromium.org/2224223002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java (right): https://codereview.chromium.org/2224223002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java#newcode78 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:78: private List<PwsResult> mPwsResults; On 2016/08/10 00:29:18, dfalcantara wrote: > ...
4 years, 4 months ago (2016-08-12 18:22:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224223002/20001
4 years, 4 months ago (2016-08-12 18:22:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 19:05:14 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 19:07:51 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ba64b349e320be7a35c42dcdfbdeaea9ae412b3
Cr-Commit-Position: refs/heads/master@{#411724}

Powered by Google App Engine
This is Rietveld 408576698