Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: components/security_state/security_state_model.cc

Issue 2224193003: Rename SecurityStateModel::MIXED_CONTENT_STATUS enum values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/security_state_model.cc
diff --git a/components/security_state/security_state_model.cc b/components/security_state/security_state_model.cc
index 4084402f050039697445c820841a3010ab72a643..4fb246317408ac6c2f4cccfaaa9d6078bb4b78a5 100644
--- a/components/security_state/security_state_model.cc
+++ b/components/security_state/security_state_model.cc
@@ -72,19 +72,19 @@ SecurityStateModel::SHA1DeprecationStatus GetSHA1DeprecationStatus(
return SecurityStateModel::NO_DEPRECATED_SHA1;
}
-SecurityStateModel::MixedContentStatus GetMixedContentStatus(
+SecurityStateModel::ContentStatus GetMixedContentStatus(
const SecurityStateModel::VisibleSecurityState& visible_security_state) {
bool ran_insecure_content = visible_security_state.ran_mixed_content;
bool displayed_insecure_content =
visible_security_state.displayed_mixed_content;
if (ran_insecure_content && displayed_insecure_content)
- return SecurityStateModel::RAN_AND_DISPLAYED_MIXED_CONTENT;
+ return SecurityStateModel::CONTENT_STATUS_DISPLAYED_AND_RAN;
if (ran_insecure_content)
- return SecurityStateModel::RAN_MIXED_CONTENT;
+ return SecurityStateModel::CONTENT_STATUS_RAN;
if (displayed_insecure_content)
- return SecurityStateModel::DISPLAYED_MIXED_CONTENT;
+ return SecurityStateModel::CONTENT_STATUS_DISPLAYED;
- return SecurityStateModel::NO_MIXED_CONTENT;
+ return SecurityStateModel::CONTENT_STATUS_NONE;
}
SecurityStateModel::SecurityLevel GetSecurityLevelForRequest(
@@ -92,7 +92,7 @@ SecurityStateModel::SecurityLevel GetSecurityLevelForRequest(
SecurityStateModelClient* client,
const scoped_refptr<net::X509Certificate>& cert,
SecurityStateModel::SHA1DeprecationStatus sha1_status,
- SecurityStateModel::MixedContentStatus mixed_content_status) {
+ SecurityStateModel::ContentStatus mixed_content_status) {
DCHECK(visible_security_state.initialized);
GURL url = visible_security_state.url;
switch (visible_security_state.initial_security_level) {
@@ -119,9 +119,9 @@ SecurityStateModel::SecurityLevel GetSecurityLevelForRequest(
!net::IsCertStatusMinorError(cert_status)) {
return SecurityStateModel::SECURITY_ERROR;
}
- if (mixed_content_status == SecurityStateModel::RAN_MIXED_CONTENT ||
+ if (mixed_content_status == SecurityStateModel::CONTENT_STATUS_RAN ||
mixed_content_status ==
- SecurityStateModel::RAN_AND_DISPLAYED_MIXED_CONTENT) {
+ SecurityStateModel::CONTENT_STATUS_DISPLAYED_AND_RAN) {
return SecurityStateModel::kRanInsecureContentLevel;
}
@@ -139,10 +139,10 @@ SecurityStateModel::SecurityLevel GetSecurityLevelForRequest(
return SecurityStateModel::NONE;
// Active mixed content is handled above.
- DCHECK_NE(SecurityStateModel::RAN_MIXED_CONTENT, mixed_content_status);
- DCHECK_NE(SecurityStateModel::RAN_AND_DISPLAYED_MIXED_CONTENT,
+ DCHECK_NE(SecurityStateModel::CONTENT_STATUS_RAN, mixed_content_status);
+ DCHECK_NE(SecurityStateModel::CONTENT_STATUS_DISPLAYED_AND_RAN,
mixed_content_status);
- if (mixed_content_status == SecurityStateModel::DISPLAYED_MIXED_CONTENT)
+ if (mixed_content_status == SecurityStateModel::CONTENT_STATUS_DISPLAYED)
return SecurityStateModel::kDisplayedInsecureContentLevel;
if (net::IsCertStatusError(cert_status)) {
@@ -212,7 +212,7 @@ const SecurityStateModel::SecurityLevel
SecurityStateModel::SecurityInfo::SecurityInfo()
: security_level(SecurityStateModel::NONE),
sha1_deprecation_status(SecurityStateModel::NO_DEPRECATED_SHA1),
- mixed_content_status(SecurityStateModel::NO_MIXED_CONTENT),
+ mixed_content_status(SecurityStateModel::CONTENT_STATUS_NONE),
scheme_is_cryptographic(false),
cert_status(0),
cert_id(0),

Powered by Google App Engine
This is Rietveld 408576698