Added different colors for success/failure and code search.

scripts/slave/recipe_modules/chromium_android/resources/test_results_presentation.py

 #! /usr/bin/env python
 # Copyright 2016 The Chromium Authors. All Rights Reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import json
 import logging
 import os
 import sys
@@ skipping 19 matching lines @@
             {
                 'name': test,
                 'status': tr['status'],
                 'duration': tr['elapsed_time_ms'],
                 'output_snippet' : tr['output_snippet']
             } for tr in test_runs])
     return results_to_html(results_list)
 
 # Convert list of test results into html format.
 def results_to_html(results):
+  def code_search(test):

[the real yoland, 2016/08/08 22:34:51]

nice, this is much cleaner than my idea of using javascript to do it

[BigBossZhiling, 2016/08/10 20:17:00]

Acknowledged.

+    search = test.replace('#', '.')
+    return 'https://cs.corp.google.com/search/?q=%s&type=cs' % search

[the real yoland, 2016/08/08 22:34:51]

this is a bit tricky, because internal links can't be shown in a open sourced
script, you will have to create an argument in the script to pass in the link if
it's downstream, and if it's upstream, the script can use the default upstream
code search link here (https://cs.chromium.org)

[BigBossZhiling, 2016/08/10 20:16:59]

Done.

   suite_row_dict = {}
   test_row_list = []
   for result in results:
-    data = [{'data': result['name'], 'class': 'align-left'},
-            {'data': result['status'], 'class': 'align-center'},
-            {'data': result['duration'], 'class': 'align-center'},
-            {'data': result['output_snippet'], 'class': 'align-left is-pre'}]
+    data = [{'data': result['name'], 'class': 'left', 

[the real yoland, 2016/08/08 22:34:51]

nit: extra space

[BigBossZhiling, 2016/08/10 20:17:00]

Done.

+             'link': code_search(result['name'])},
+            {'data': result['status'], 
+             'class': 'center ' + result['status'].lower()},
+            {'data': result['duration'], 'class': 'center'},
+            {'data': result['output_snippet'], 
+             'class': 'left', 'is_pre': True}]
 
     test_row_list.append(data)
     suite_name = result['name'][:result['name'].index('#')]

[the real yoland, 2016/08/08 22:34:50]

nit: add the comment here to separate constructions of test_row_list and
suite_row_dict

extra nit:
test_case_path = result['name']
test_suite_name = test_case_path[:test_case_path.index('#')]

[BigBossZhiling, 2016/08/10 20:16:59]

Done.

 
     # 'suite_row' is [name, success_count, fail_count, all_count, time].
     SUCCESS_COUNT = 1
     FAIL_COUNT = 2
     ALL_COUNT = 3
     TIME = 4
 
     if suite_name in suite_row_dict:
       suite_row = suite_row_dict[suite_name]  
     else:
-      suite_row = [{'data': suite_name, 'class' : 'align-left'},
-                   {'data': 0, 'class': 'align-center'},
-                   {'data': 0, 'class': 'align-center'},
-                   {'data': 0, 'class': 'align-center'},
-                   {'data': 0, 'class': 'align-center'}]
+      suite_row = [{'data': suite_name, 'class' : 'left'},
+                   {'data': 0, 'class': 'center'},
+                   {'data': 0, 'class': 'center'},
+                   {'data': 0, 'class': 'center'},
+                   {'data': 0, 'class': 'center'}]
       suite_row_dict[suite_name] = suite_row
 
     suite_row[ALL_COUNT]['data'] += 1
     if result['status'] == 'SUCCESS':
       suite_row[SUCCESS_COUNT]['data'] += 1
     elif result['status'] == 'FAILURE':
       suite_row[FAIL_COUNT]['data'] += 1
     suite_row[TIME]['data'] += result['duration']
 
+  for suite in suite_row_dict.values():
+    if suite[FAIL_COUNT]['data'] > 0:
+      suite[FAIL_COUNT]['class'] += ' failure'
+    else:
+      suite[FAIL_COUNT]['class'] += ' success'
+
   test_table_values = {
     'table_id' : 'test_table',
     'table_headers' : [('text', 'test_name'),
                        ('text', 'status'),
                        ('number', 'duration'),
                        ('text', 'output_snippet'),
                       ],
+    'table_class' : 'info',
     'table_rows' : test_row_list,
   }
 
   suite_table_values = {
     'table_id' : 'suite_table',
     'table_headers' : [('text', 'suite_name'),
                        ('number', 'number_success_tests'),
                        ('number', 'number_fail_tests'),
                        ('number', 'all_tests'),
                        ('number', 'elapsed_time_ms'),
                       ],
+    'table_class' : 'info',
     'table_rows' : suite_row_dict.values(),
   }
 
   main_template = jinja_environment.get_template(
       os.path.join('template', 'main.html'))
   return main_template.render(
       {'tb_values': [suite_table_values, test_table_values]})
 
 def main():
   logging.basicConfig(level=logging.INFO)
   parser = argparse.ArgumentParser()
   parser.add_argument('--json-file', help='Path of json file.', required=True)
   parser.add_argument('--html-file', help='Path to store html file.',
                       required=True)
   args = parser.parse_args()
   if os.path.exists(args.json_file):
     result_html_string = result_details(args.json_file)
 
     with open(args.html_file, 'w') as html:
       html.write(result_html_string)
   else:
-    raise exception('Json file of result details is not found.')
+    raise Exception('Json file of result details is not found.')
 
 if __name__ == '__main__':
   sys.exit(main())