Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4951)

Unified Diff: chrome/test/data/webui/settings/settings_page_browsertest.js

Issue 2224163002: Settings Router Refactor: Replace route.subpage usage with route.path (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/settings/route_tests.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/settings_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_page_browsertest.js b/chrome/test/data/webui/settings/settings_page_browsertest.js
index 7e60116464fcb0274da8d111d22c18e8c7aa30a9..cb75c4dc24f80ee34fd37341e6911997095fe0b9 100644
--- a/chrome/test/data/webui/settings/settings_page_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_page_browsertest.js
@@ -92,15 +92,15 @@ SettingsPageBrowserTest.prototype = {
// The section's main child should be stamped and visible.
var main = stampedChildren.filter(function(element) {
- return element.id == 'main';
+ return element.getAttribute('route-path') == 'default';
});
- assertEquals(main.length, 1, '#main not found for section ' +
+ assertEquals(main.length, 1, 'default card not found for section ' +
section.section);
assertGT(main[0].offsetHeight, 0);
// Any other stamped subpages should not be visible.
var subpages = stampedChildren.filter(function(element) {
- return element.id != 'main';
+ return element.getAttribute('route-path') != 'default';
});
for (var subpage of subpages) {
assertEquals(subpage.offsetHeight, 0, 'Expected subpage #' + subpage.id +
« no previous file with comments | « chrome/test/data/webui/settings/route_tests.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698