Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9005)

Unified Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2224163002: Settings Router Refactor: Replace route.subpage usage with route.path (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/languages_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/languages_page_browsertest.js b/chrome/test/data/webui/settings/languages_page_browsertest.js
index e327fcd18525fcac8e9392f75bbd8ebda6a16fce..da3690bb9de7525303c651a1418bc47bd4e1ac41 100644
--- a/chrome/test/data/webui/settings/languages_page_browsertest.js
+++ b/chrome/test/data/webui/settings/languages_page_browsertest.js
@@ -68,11 +68,11 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
teardown(function(done) {
// Close the section if we're in a sub-page.
- if (settings.getCurrentRoute().subpage.length == 0) {
- done();
- } else {
+ if (settings.getCurrentRoute().isSubpage()) {
settings.navigateTo(settings.Route.ADVANCED);
setTimeout(done);
+ } else {
+ done();
}
});
« no previous file with comments | « chrome/test/data/webui/settings/device_page_tests.js ('k') | chrome/test/data/webui/settings/route_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698