chrome/browser/resources/settings/search_page/search_page.html - Issue 2224163002: Settings Router Refactor: Replace route.subpage usage with route.path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 2224163002: Settings Router Refactor: Replace route.subpage usage with route.path (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/route.js ('k') | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_page/search_page.html

diff --git a/chrome/browser/resources/settings/search_page/search_page.html b/chrome/browser/resources/settings/search_page/search_page.html

index c85e1090c7df234981fe8804bdc3ead483ba7f03..b6a175a710a5aaf1c16747184d361cdac7697ff2 100644

--- a/chrome/browser/resources/settings/search_page/search_page.html

+++ b/chrome/browser/resources/settings/search_page/search_page.html

@@ -15,7 +15,7 @@

</style>

<settings-animated-pages id="pages" section="search">

- <neon-animatable id="main">

+ <neon-animatable route-path="default">

<p class="start">$i18n{searchExplanation}</p>

<paper-dropdown-menu vertical-align="auto" no-label-float>

@@ -37,7 +37,7 @@

</paper-button>

</div>

</neon-animatable>

- <template is="dom-if" name="search-engines">

+ <template is="dom-if" route-path="/searchEngines">

<settings-subpage

associated-control="[[$$('#subpage-trigger')]]"

page-title="$i18n{searchEnginesManage}">

« no previous file with comments | « chrome/browser/resources/settings/route.js ('k') | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »