chrome/browser/resources/settings/printing_page/printing_page.html - Issue 2224163002: Settings Router Refactor: Replace route.subpage usage with route.path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/printing_page/printing_page.html

Issue 2224163002: Settings Router Refactor: Replace route.subpage usage with route.path (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.html ('k') | chrome/browser/resources/settings/privacy_page/privacy_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/printing_page/printing_page.html

diff --git a/chrome/browser/resources/settings/printing_page/printing_page.html b/chrome/browser/resources/settings/printing_page/printing_page.html

index f54a418fd432f66197f5babf0039d0ccbb962826..c72cc1108742a5772027f194e8bd03fa2c67198d 100644

--- a/chrome/browser/resources/settings/printing_page/printing_page.html

+++ b/chrome/browser/resources/settings/printing_page/printing_page.html

@@ -19,7 +19,7 @@

<array-selector id="arraySelector" items="{{cupsPrinters}}"

selected="{{detailPrinter_}}">

</array-selector>

- <neon-animatable id="main">

+ <neon-animatable route-path="default">

<div id="cupsPrinters" class="settings-box first"

on-tap="onTapCupsPrinters_" actionable>

@@ -34,7 +34,7 @@

</div>

</neon-animatable>

- <template is="dom-if" name="cups-printers">

+ <template is="dom-if" route-path="/cupsPrinters">

<settings-subpage

associated-control="[[$$('#cupsPrinters')]]"

page-title="$i18n{cupsPrintersTitle}">

@@ -42,14 +42,14 @@

</settings-cups-printers>

</settings-subpage>

</template>

- <template is="dom-if" name="cups-printer-details-page" restamp no-search>

+ <template is="dom-if" route-path="/cupsPrinterDetails" restamp no-search>

<settings-subpage page-title="$i18n{printerDetailsTitle}">

<settings-cups-printer-details-page printer="{{detailPrinter_}}">

</settings-cups-printer-details-page>

</settings-subpage>

</template>

</if>

- <template is="dom-if" name="cloud-printers">

+ <template is="dom-if" route-path="/cloudPrinters">

<settings-subpage

associated-control="[[$$('#cloudPrinters')]]"

page-title="$i18n{cloudPrintersTitle}">