Settings Router Refactor: Replace route.subpage usage with route.path

chrome/browser/resources/settings/settings_main/settings_main.js

Index: chrome/browser/resources/settings/settings_main/settings_main.js
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js
index 676429b994c7533a5426cb7ced6b98673c6cadf0..f0ce3fd64e3d45d1c638d541926907880f168bea 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.js
+++ b/chrome/browser/resources/settings/settings_main/settings_main.js
@@ -123,7 +123,7 @@ Polymer({
 
   /** @protected */
   currentRouteChanged: function(newRoute) {
-    this.inSubpage_ = newRoute.subpage.length > 0;
+    this.inSubpage_ = newRoute.isSubpage();
     this.style.height = this.inSubpage_ ? '100%' : '';

[michaelpg, 2016/08/10 18:45:52]

inSubpage_ really means whether a subpage contains this route, dialogs included
(when opened from a subpage) -- maybe it would be easier now to use the
opposite, e.g. this.onRootPage_

for instance, i'd expect this to cause style problems if the dialog is opened
from a subpage

[tommycli, 2016/08/10 18:52:17]

Yeah, I'll just suggest that dialogs can never be from within subpages.

 
     if (settings.Route.ABOUT.contains(newRoute)) {
@@ -162,7 +162,7 @@ Polymer({
    */
   overscrollHeight_: function() {
     var route = settings.getCurrentRoute();
-    if (route.subpage.length != 0 || this.showPages_.about)
+    if (route.isSubpage() || this.showPages_.about)
       return 0;
 
     var query = 'settings-section[section="' + route.section + '"]';