Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2318)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2224163002: Settings Router Refactor: Replace route.subpage usage with route.path (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index 0e41e7b1ecb04235b8b25ba30498d88365fe9e2c..ff0f01e357a562a17fdd83b64208e049d8aa52d9 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -73,7 +73,7 @@
}
</style>
<settings-animated-pages id="pages" section="people">
- <neon-animatable id="main">
+ <neon-animatable route-path="default">
<div id="picture-subpage-trigger" class="settings-box first two-line">
<img id="profile-icon" src="[[profileIconUrl_]]"
on-tap="onPictureTap_" actionable>
@@ -235,7 +235,7 @@
</template>
</neon-animatable>
<template is="dom-if" if="[[isAdvancedSyncSettingsVisible_(syncStatus)]]">
- <template is="dom-if" name="sync">
+ <template is="dom-if" route-path="/syncSetup">
<settings-subpage
associated-control="[[$$('#customize-sync')]]"
page-title="$i18n{syncPageTitle}">
@@ -244,7 +244,7 @@
</template>
</template>
<if expr="chromeos">
- <template is="dom-if" name="quick-unlock-authenticate" no-search>
+ <template is="dom-if" route-path="/quickUnlock/authenticate" no-search>
<settings-subpage page-title="$i18n{quickUnlockTitle}">
<settings-quick-unlock-authenticate
set-modes="{{quickUnlockSetModes}}"
@@ -252,27 +252,27 @@
</settings-quick-unlock-authenticate>
</settings-subpage>
</template>
- <template is="dom-if" name="quick-unlock-choose-method" no-search>
+ <template is="dom-if" route-path="/quickUnlock/chooseMethod" no-search>
<settings-subpage page-title="$i18n{quickUnlockTitle}">
<settings-quick-unlock-choose-method
set-modes="[[quickUnlockSetModes]]" prefs="{{prefs}}">
</settings-quick-unlock-choose-method>
</settings-subpage>
</template>
- <template is="dom-if" name="quick-unlock-setup-pin" no-search>
+ <template is="dom-if" route-path="/quickUnlock/setupPin" no-search>
<settings-subpage page-title="$i18n{quickUnlockTitle}">
<settings-quick-unlock-setup-pin set-modes="[[quickUnlockSetModes]]">
</settings-quick-unlock-setup-pin>
</settings-subpage>
</template>
- <template is="dom-if" name="users">
+ <template is="dom-if" route-path="/accounts">
<settings-subpage
associated-control="[[$$('#manage-other-people-subpage-trigger')]]"
page-title="$i18n{usersPageTitle}">
<settings-users-page prefs="{{prefs}}"></settings-users-page>
</settings-subpage>
</template>
- <template is="dom-if" name="changePicture">
+ <template is="dom-if" route-path="/changePicture">
<settings-subpage
associated-control="[[$$('#picture-subpage-trigger')]]"
page-title="$i18n{changePictureTitle}">
@@ -281,7 +281,7 @@
</template>
</if>
<if expr="not chromeos">
- <template is="dom-if" name="manageProfile">
+ <template is="dom-if" route-path="/manageProfile">
<settings-subpage
associated-control="[[$$('#picture-subpage-trigger')]]"
page-title="$i18n{editPerson}">

Powered by Google App Engine
This is Rietveld 408576698