Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 2224153003: [heap] Enable black allocation when finalizing incremental marking. (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Enable black allocation when finalizing incremental marking. BUG=chromium:630386 Committed: https://crrev.com/bb4e028648a27a6958afc9b5040366b899cda50d Cr-Commit-Position: refs/heads/master@{#38487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Lippautz
lgtm
4 years, 4 months ago (2016-08-09 11:31:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224153003/1
4 years, 4 months ago (2016-08-09 11:55:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 12:06:24 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bb4e028648a27a6958afc9b5040366b899cda50d Cr-Commit-Position: refs/heads/master@{#38487}
4 years, 4 months ago (2016-08-09 12:06:42 UTC) #11
Hannes Payer (out of office)
4 years, 4 months ago (2016-08-09 12:58:14 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2223423003/ by hpayer@chromium.org.

The reason for reverting is: crashing on ToT.

Powered by Google App Engine
This is Rietveld 408576698