tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py - Issue 222413002: Adding dumpsys based power monitor for android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py

Issue 222413002: Adding dumpsys based power monitor for android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Follow review Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor_unittest.py ('K') | « tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py ('k') | tools/telemetry/unittest_data/batterystats.csv » ('j') | tools/telemetry/unittest_data/batterystats.csv » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py b/tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py

index df3c09487d24ac84dc8798ed5790f53705eede31..5d046a2a93819c4ff60d8c6b6005956a90f9ef2e 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py

@@ -20,7 +20,7 @@ class PowerMetricsPowerMonitorTest(unittest.TestCase):

mavericks_or_later = (

backend.GetOSVersionName() >= mac_platform_backend.MAVERICKS)

# Should always be able to monitor power usage on OS Version >= 10.9 .

- self.assertEqual(power_monitor.CanMonitorPowerAsync(), mavericks_or_later,

+ self.assertEqual(power_monitor.CanMonitorPower(), mavericks_or_later,

"Error checking powermetrics availability: '%s'" % '|'.join(os.uname()))

@test.Enabled('mac')

@@ -40,7 +40,7 @@ class PowerMetricsPowerMonitorTest(unittest.TestCase):

power_monitor = powermetrics_power_monitor.PowerMetricsPowerMonitor(

mac_platform_backend.MacPlatformBackend())

- if not power_monitor.CanMonitorPowerAsync():

+ if not power_monitor.CanMonitorPower():

logging.warning('Test not supported on this platform.')

return