Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: cc/output/overlay_unittest.cc

Issue 2224113002: Implement new RPDQ copy logic for CALayer promotion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/overlay_processor.cc ('k') | cc/quads/render_pass_draw_quad.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/overlay_unittest.cc
diff --git a/cc/output/overlay_unittest.cc b/cc/output/overlay_unittest.cc
index 1b7c3a2fae5515c66fede63e04ce4a95ad7f4a1b..c289621615a30648f2e5b580229fabd47fea456e 100644
--- a/cc/output/overlay_unittest.cc
+++ b/cc/output/overlay_unittest.cc
@@ -1141,7 +1141,7 @@ TEST_F(CALayerOverlayTest, AllowNonAxisAlignedTransform) {
overlay_processor_->ProcessForOverlays(resource_provider_.get(), pass.get(),
&overlay_list, &ca_layer_list,
&damage_rect);
- EXPECT_EQ(0U, pass->quad_list.size());
+ EXPECT_EQ(gfx::Rect(), damage_rect);
EXPECT_EQ(0U, overlay_list.size());
EXPECT_EQ(1U, ca_layer_list.size());
EXPECT_EQ(0U, output_surface_->bind_framebuffer_count());
@@ -1184,7 +1184,7 @@ TEST_F(CALayerOverlayTest, AllowContainingClip) {
overlay_processor_->ProcessForOverlays(resource_provider_.get(), pass.get(),
&overlay_list, &ca_layer_list,
&damage_rect);
- EXPECT_EQ(0U, pass->quad_list.size());
+ EXPECT_EQ(gfx::Rect(), damage_rect);
EXPECT_EQ(0U, overlay_list.size());
EXPECT_EQ(1U, ca_layer_list.size());
EXPECT_EQ(0U, output_surface_->bind_framebuffer_count());
@@ -1204,7 +1204,7 @@ TEST_F(CALayerOverlayTest, NontrivialClip) {
overlay_processor_->ProcessForOverlays(resource_provider_.get(), pass.get(),
&overlay_list, &ca_layer_list,
&damage_rect);
- EXPECT_EQ(0U, pass->quad_list.size());
+ EXPECT_EQ(gfx::Rect(), damage_rect);
EXPECT_EQ(0U, overlay_list.size());
EXPECT_EQ(1U, ca_layer_list.size());
EXPECT_TRUE(ca_layer_list.back().shared_state->is_clipped);
@@ -1226,7 +1226,7 @@ TEST_F(CALayerOverlayTest, SkipTransparent) {
overlay_processor_->ProcessForOverlays(resource_provider_.get(), pass.get(),
&overlay_list, &ca_layer_list,
&damage_rect);
- EXPECT_EQ(0U, pass->quad_list.size());
+ EXPECT_EQ(gfx::Rect(), damage_rect);
EXPECT_EQ(0U, overlay_list.size());
EXPECT_EQ(0U, ca_layer_list.size());
EXPECT_EQ(0U, output_surface_->bind_framebuffer_count());
@@ -1823,7 +1823,7 @@ TEST_F(CALayerOverlayRPDQTest, RenderPassDrawQuadBlurFilterScale) {
kOverlayRect, render_pass_id_, 0, gfx::Vector2dF(), gfx::Size(),
filters_, gfx::Vector2dF(1, 2), background_filters_);
ProcessForOverlays();
- EXPECT_EQ(0U, ca_layer_list_.size());
+ EXPECT_EQ(1U, ca_layer_list_.size());
}
TEST_F(CALayerOverlayRPDQTest, RenderPassDrawQuadDropShadowFilterScale) {
@@ -1833,7 +1833,7 @@ TEST_F(CALayerOverlayRPDQTest, RenderPassDrawQuadDropShadowFilterScale) {
kOverlayRect, render_pass_id_, 0, gfx::Vector2dF(), gfx::Size(),
filters_, gfx::Vector2dF(1, 2), background_filters_);
ProcessForOverlays();
- EXPECT_EQ(0U, ca_layer_list_.size());
+ EXPECT_EQ(1U, ca_layer_list_.size());
}
TEST_F(CALayerOverlayRPDQTest, RenderPassDrawQuadBackgroundFilter) {
@@ -1850,7 +1850,7 @@ TEST_F(CALayerOverlayRPDQTest, RenderPassDrawQuadMask) {
kOverlayRect, render_pass_id_, 2, gfx::Vector2dF(), gfx::Size(),
filters_, gfx::Vector2dF(1, 1), background_filters_);
ProcessForOverlays();
- EXPECT_EQ(0U, ca_layer_list_.size());
+ EXPECT_EQ(1U, ca_layer_list_.size());
}
TEST_F(CALayerOverlayRPDQTest, RenderPassDrawQuadUnsupportedFilter) {
« no previous file with comments | « cc/output/overlay_processor.cc ('k') | cc/quads/render_pass_draw_quad.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698