services/video_capture/service_main.cc - Issue 2224103002: Package video capture skeleton as Mojo Shell Service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/video_capture/service_main.cc

Issue 2224103002: Package video capture skeleton as Mojo Shell Service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@VideoMojoSkeleton2

Patch Set: yzshen's comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « services/video_capture/public/interfaces/video_capture_device_factory.mojom ('k') | services/video_capture/service_manifest.json » ('j') | services/video_capture/service_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/sysui/sysui_application.h"

6 #include "services/shell/public/c/main.h"	5 #include "services/shell/public/c/main.h"

7 #include "services/shell/public/cpp/service_runner.h"	6 #include "services/shell/public/cpp/service_runner.h"

	7 #include "services/video_capture/video_capture_service.h"

8	8

9 MojoResult ServiceMain(MojoHandle service_request_handle) {	9 MojoResult ServiceMain(MojoHandle service_request_handle) {

10 shell::ServiceRunner runner(new ash::sysui::SysUIApplication);	10 return shell::ServiceRunner(new video_capture::VideoCaptureService)

11 return runner.Run(service_request_handle);	11 .Run(service_request_handle);

12 }	12 }
	mcasas 2016/08/12 21:45:27 Pro-tip: when uploading a CL, you can set the simi Pro-tip: when uploading a CL, you can set the similarity like, e.g. `git cl upload -t "bla" --similarity=75` and that'll remove this false-diffs, instead correctly indicating that service_main.cc is a new file. chfremer 2016/08/12 22:23:24 Acknowledged. Show quoted text On 2016/08/12 21:45:27, mcasas wrote: > Pro-tip: when uploading a CL, you can set the similarity > like, e.g. `git cl upload -t "bla" --similarity=75` and that'll > remove this false-diffs, instead correctly indicating that > service_main.cc is a new file. Acknowledged.
OLD	NEW